adding to log traces, set env SKR_TRACE_ON for failed cases #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajosh
requested review from
Jyotsna-Anand,
ShridharParameshwarBhat,
aravindthoram,
bamuir,
canfikret and
vimish
canfikret
requested changes
Nov 29, 2023
| if manage_id: | ||
| raise Exception ('{0} Encryption managed identity: {1}'.format(msg,manage_id)) | ||
| raise Exception(msg) | ||
| #SKR is failed trace the logs. |
Member
There was a problem hiding this comment.
Nit: # SKR has failed. Turn on tracing and log the output.
|
@pankajosh we have this open PR that would be good to test with this; It has been open for some time now. Can you add the console device path fix to your tests? I have not validated that PR but we should investigate what the issue/fix is |
canfikret
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding SKR attestation traces for failure in SKR.