Skip to content

Conversation

@ag-ramachandran
Copy link
Contributor

Address review comments that came up in the review session. The following key points are addressed

a) Move DB and table to ingestAsync , not in IngestRequestProperties. IRP can be completely a basic one without user having to create it everytime.
b) Validation to check if there are contradictory IngestRequestProperties (Mapping and MappingReference)
c) IngestRequestProperties can it be a C'tor or a Builder pattern?
d) Samples to use AzCli or AppId key to authenticate. Using ChainedTokenCredential may confuse users.
e) BaseName for source has to be optional. A lot of thought was put into C# to get context and debugging.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the ingest-v2 API to address review feedback. The main changes move database and table parameters from IngestRequestProperties to the ingestAsync methods, making IngestRequestProperties a simpler, reusable configuration object. The PR also consolidates ingestion mapping handling, removes the baseName parameter from sources (making it optional as requested), and simplifies authentication samples.

Changes:

  • Moved database and table from IngestRequestProperties to ingestAsync method parameters
  • Unified IngestionMapping class (replacing InlineIngestionMapping and reference-based approaches)
  • Removed baseName parameter from source constructors
  • Made IngestRequestProperties nullable to allow minimal configuration
  • Simplified authentication in samples (QueuedIngestV2 updated, others partially)

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
IngestRequestPropertiesBuilder.kt Removed database/table parameters from create(), unified mapping handling
IngestClient.kt Added database/table parameters to ingestAsync signatures
StreamingIngestClient.kt Updated to accept database/table parameters, handle nullable properties
QueuedIngestClient.kt Updated signatures and null handling for properties
ManagedStreamingIngestClient.kt Updated with new API signature and effective properties handling
IngestionMapping.kt New unified class replacing InlineIngestionMapping
IngestionSource.kt Removed baseName parameter, simplified name generation
Sample files Updated to use new API, simplified authentication in QueuedIngestV2
Test files Comprehensive updates for new API, including null properties testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Test Results

530 tests  ±0   521 ✅ ±0   8m 11s ⏱️ + 4m 47s
 31 suites ±0     9 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit c486771. ± Comparison against base commit b9ccf14.

@github-actions
Copy link

Test Results

530 tests  ±0   521 ✅ ±0   8m 3s ⏱️ + 4m 39s
 31 suites ±0     9 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit c486771. ± Comparison against base commit b9ccf14.

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Test Results

530 tests  ±0   521 ✅ ±0   8m 13s ⏱️ + 4m 49s
 31 suites ±0     9 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit dc81dd9. ± Comparison against base commit b9ccf14.

♻️ This comment has been updated with latest results.

@tanmaya-panda1 tanmaya-panda1 merged commit ce36f64 into feature/IngestV2 Jan 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants