Add account name and login type to JSON response for azd auth login --check-status #5404

Copilot · 2025-06-25T22:38:15Z

Adds optional fields to the contracts.LoginResult struct and updated the authentication logic to populate these fields when the user is authenticated.

The JSON response now includes account information:

{
  "status": "success",
  "expiresOn": "2025-07-08T20:20:26Z",
  "principal": {
    "name": "useremail",
    "type": "User"
  }
}

Fixes #5402

…-check-status Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

vhvb1989 · 2025-06-25T23:25:05Z

/azp run azure-dev - cli

azure-pipelines · 2025-06-25T23:25:44Z

Azure Pipelines successfully started running 1 pipeline(s).

cli/azd/cmd/auth_login.go

…eck-status Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

cli/azd/pkg/contracts/login.go

… PrincipalType Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot · 2025-06-27T23:58:10Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

downloads.bicep.azure.com
- Triggering command: /tmp/go-build448698095/b001/bicep.test -test.testlogfile=/tmp/go-build448698095/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.short=true (dns block)
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
- Triggering command: /tmp/go-build2962273189/b001/bicep.test -test.testlogfile=/tmp/go-build2962273189/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.run=TestPromptForParameter -test.short=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

weikanglim · 2025-06-30T18:55:28Z

cli/azd/pkg/output/ux/logged_in.go

+	UserLoginType             LoginType = "User"
+	ServicePrincipalLoginType LoginType = "ServicePrincipal"
 )


@copilot Move the login type declarations to login.go in contracts package

Moved the LoginType declarations from ux/logged_in.go to the contracts package as requested. This centralizes the login type definitions and removes duplication across packages. Commit 4de5daa

weikanglim · 2025-06-30T18:56:03Z

cli/azd/pkg/contracts/login.go

 	ExpiresOn *time.Time `json:"expiresOn,omitempty"`
+	// When status is `LoginStatusSuccess`, the account name the user is logged in as.
+	Account *string `json:"account,omitempty"`
+	// When status is `LoginStatusSuccess`, the type of login (email or clientId).


@copilot update this documentation to reflect the actual values (User or ServicePrincipal)

Updated the documentation to reflect the actual values (User or ServicePrincipal) in commit 4de5daa

Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot · 2025-06-30T19:12:47Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

downloads.bicep.azure.com
- Triggering command: /tmp/go-build734126665/b001/bicep.test -test.testlogfile=/tmp/go-build734126665/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.short=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

weikanglim · 2025-07-01T16:15:05Z

cli/azd/pkg/contracts/login.go

 import "time"

+// LoginType represents the type of authentication used
+type LoginType string


@copilot change this to PrincipalType to reflect the type of principal

Changed LoginType to PrincipalType and updated all references throughout the codebase. Also renamed the constants to UserPrincipalType and ServicePrincipalPrincipalType for consistency. Commit 1f023b0

weikanglim · 2025-07-01T16:18:52Z

cli/azd/pkg/contracts/login.go

+	// When status is `LoginStatusSuccess`, the type of login (User or ServicePrincipal).
+	LoginType *LoginType `json:"loginType,omitempty"`


@copilot make the new fields principal.name and principal.type to be more consistent with the current contracted usage in azd env variables AZURE_PRINCIPAL_xx

Changed the JSON structure to use nested principal.name and principal.type fields to be consistent with the AZURE_PRINCIPAL_* environment variable naming convention. Commit 81fb55b

Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot · 2025-07-01T16:30:45Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

downloads.bicep.azure.com
- Triggering command: /tmp/go-build871652250/b893/bicep.test -test.testlogfile=/tmp/go-build871652250/b893/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.short=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

…type fields Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

microsoft-github-policy-service · 2025-09-12T05:36:18Z

Hi @@copilot. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

microsoft-github-policy-service · 2025-09-19T16:03:42Z

Hi @@copilot. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

rajeshkamal5050 · 2026-01-05T17:16:41Z

@JeffreyCA @weikanglim can we review and move this PR along?

weikanglim · 2026-01-06T20:31:24Z

@rajeshkamal5050 This will be merged with the new auth status command #6377.

weikanglim · 2026-01-06T22:19:02Z

Superseded by #6377

Initial plan

3c4e74f

Copilot AI assigned Copilot and weikanglim Jun 25, 2025

Copilot started work on behalf of weikanglim June 25, 2025 22:38 View session

Add account name and login type to JSON response for azd auth login -…

2687b31

…-check-status Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] [Issue] Account name not included in JSON response when running azd auth login --check-status -o json~~ Add account name and login type to JSON response for azd auth login --check-status Jun 25, 2025

Copilot AI requested a review from weikanglim June 25, 2025 22:48

Copilot finished work on behalf of weikanglim June 25, 2025 22:48

weikanglim reviewed Jun 25, 2025

View reviewed changes

cli/azd/cmd/auth_login.go Outdated Show resolved Hide resolved

Copilot started work on behalf of weikanglim June 25, 2025 23:26 View session

vhvb1989 reviewed Jun 25, 2025

View reviewed changes

cli/azd/cmd/auth_login.go Outdated Show resolved Hide resolved

Remove redundant logic for getting account details in auth login --ch…

8369592

…eck-status Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot AI requested a review from weikanglim June 25, 2025 23:32

Copilot finished work on behalf of weikanglim June 25, 2025 23:32

Copilot started work on behalf of vhvb1989 June 25, 2025 23:32 View session

Copilot finished work on behalf of vhvb1989 June 25, 2025 23:38

Copilot AI requested a review from vhvb1989 June 25, 2025 23:38

vhvb1989 marked this pull request as ready for review June 26, 2025 17:49

vhvb1989 requested review from hemarina, rajeshkamal5050, tg-msft and wbreza as code owners June 26, 2025 17:49

weikanglim reviewed Jun 27, 2025

View reviewed changes

cli/azd/pkg/contracts/login.go Outdated Show resolved Hide resolved

Copilot started work on behalf of weikanglim June 27, 2025 23:47 View session

Change LoginType values to 'User' and 'ServicePrincipal' and refactor…

4b2acd5

… PrincipalType Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot AI requested a review from weikanglim June 27, 2025 23:58

Copilot finished work on behalf of weikanglim June 27, 2025 23:58

weikanglim reviewed Jun 30, 2025

View reviewed changes

Copilot started work on behalf of weikanglim June 30, 2025 18:55 View session

weikanglim reviewed Jun 30, 2025

View reviewed changes

Move LoginType declarations to contracts package

4de5daa

Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot AI requested a review from weikanglim June 30, 2025 19:12

Copilot finished work on behalf of weikanglim June 30, 2025 19:12

Copilot started work on behalf of weikanglim June 30, 2025 19:12 View session

Copilot finished work on behalf of weikanglim June 30, 2025 19:16

weikanglim reviewed Jul 1, 2025

View reviewed changes

Copilot started work on behalf of weikanglim July 1, 2025 16:15 View session

weikanglim reviewed Jul 1, 2025

View reviewed changes

Rename LoginType to PrincipalType and update all references

1f023b0

Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot AI requested a review from weikanglim July 1, 2025 16:30

Copilot finished work on behalf of weikanglim July 1, 2025 16:30

Copilot started work on behalf of weikanglim July 1, 2025 16:30 View session

Restructure JSON fields to use nested principal object with name and …

81fb55b

…type fields Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>

Copilot finished work on behalf of weikanglim July 1, 2025 16:39

microsoft-github-policy-service bot added the no-recent-activity identity issues with no activity label Sep 12, 2025

microsoft-github-policy-service bot closed this Sep 19, 2025

rajeshkamal5050 removed the no-recent-activity identity issues with no activity label Jan 5, 2026

rajeshkamal5050 reopened this Jan 5, 2026

weikanglim mentioned this pull request Jan 6, 2026

Add azd auth status command #6377

Merged

weikanglim closed this Jan 6, 2026

		// When status is `LoginStatusSuccess`, the type of login (User or ServicePrincipal).
		LoginType *LoginType `json:"loginType,omitempty"`

Add account name and login type to JSON response for azd auth login --check-status #5404

Add account name and login type to JSON response for azd auth login --check-status #5404

Conversation

Copilot AI commented Jun 25, 2025 • edited by weikanglim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vhvb1989 commented Jun 25, 2025

Uh oh!

azure-pipelines bot commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jun 27, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

weikanglim Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

weikanglim Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jun 30, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

weikanglim Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

weikanglim Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 1, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

microsoft-github-policy-service bot commented Sep 12, 2025

Uh oh!

microsoft-github-policy-service bot commented Sep 19, 2025

Uh oh!

rajeshkamal5050 commented Jan 5, 2026

Uh oh!

weikanglim commented Jan 6, 2026

Uh oh!

weikanglim commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Jun 25, 2025 •

edited by weikanglim

Loading

weikanglim Jun 30, 2025 •

edited

Loading