[Backup] Fix #31946, #32571: General bugfixes for az backup job show and az backup container unregister
#32613
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andling any such scenario.
zubairabid
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an AttributeError that occurs when using az backup job show with Azure Files backup jobs. The issue arises because the AzureStorageJobTaskDetails object lacks start_time and end_time attributes that the code was attempting to access without checking for their existence.
Key Changes:
- Added
hasattrchecks inreplace_min_value_in_subtaskfunction to verify attribute existence before accessingstart_timeandend_timeon task objects
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@zhoxing-ms the test failure looks to be unrelated to our change. Please check if possible. |
Contributor
Author
|
Latest changes made to handle Bug #32571 |
zubairabid
changed the title
az backup job show: Bugfix for Azure Files backup jobsaz backup job show and az backup container unregister
zhoxing-ms
changed the title
az backup job show and az backup container unregisteraz backup job show and az backup container unregister
zhoxing-ms
changed the title
az backup job show and az backup container unregisteraz backup job show and az backup container unregister
Contributor
|
Could you add some test cases for these PR changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az backup job showaz backup container unregisterDescription
Issue described in #31946 (#31946) and in #32571.
Testing Guide
History Notes
{backup}
az backup job show: Was previously failing for Azure Files jobs. This has been rectified.{backup}
az backup container unregister: Failed for soft-deleted containers. Fix for that.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.