[Network] az network watcher flow-log: Add --record-types parameter
#32490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est_nw_flow_log.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…est_nw_flow_log.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
riddhinilawar
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network watcher flow-log create | cmd network watcher flow-log create added parameter record_types |
||
| network watcher flow-log update | cmd network watcher flow-log update added parameter record_types |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the --record-types parameter to Azure CLI's flow log commands, allowing users to filter network traffic logs based on flow states (Begin, Continue, End, Deny). The feature is implemented by updating the API version from 2024-03-01 to 2025-03-01 across multiple flow log command files.
- Added
--record-typesparameter toflow-log createandflow-log updatecommands - Updated API version to 2025-03-01 for create, update, show, delete, and wait operations
- Added unit test for flow log creation with record-types filtering
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test_nw_flow_log.py | Adds test case test_nw_flow_log_create_vnetfl_with_record_types to verify flow log creation with record-types parameter |
| _create.py | Adds --record-types parameter, updates API version to 2025-03-01, includes identity schema enhancements, and adds example for record-types usage |
| _update.py | Adds --record-types parameter to update command, updates API version to 2025-03-01, and adds example for record-types usage |
| _show.py | Updates API version to 2025-03-01, adds record_types field to response schema, and includes identity schema enhancements |
| _delete.py | Updates API version to 2025-03-01 for consistency with other flow log commands |
| _wait.py | Updates API version to 2025-03-01, adds record_types field and identity schema enhancements to response schema |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_nw_flow_log.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_nw_flow_log.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/watcher/flow_log/_create.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/watcher/flow_log/_update.py
Show resolved
Hide resolved
…est_nw_flow_log.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
riddhinilawar
changed the title
necusjz
changed the title
az network watcher flow-log: Add --record-types parameter
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
Azure/aaz#911 |
necusjz
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az network watcher flow-log create --location centraluseuap --resource-group riddhi_rg3 --name recordtype-FlowLog --vnet vnet-centraluseuap --storage-account riddhicentraluseuap --record-types "B,E"az network watcher flow-log update --location centraluseuap --resource-group riddhi_rg3 --name recordtype-FlowLog --vnet vnet-centraluseuap --storage-account riddhicentraluseuap --record-types "B,C"az network watcher flow-log show --location centraluseuap --name recordtype-FlowLogDescription
This PR introduces a new optional field, "record-types," for the creation and update of the Flowlogs resource. Necessary validations for this field have already been implemented in NRP. Unit tests for this feature have been added as part of this PR.
Additionally, screenshots of the testing performed, beyond unit tests, are included below.
Testing Guide
Help command shows the new field and its proper explanation:
az network watcher flow-log create --location centraluseuap --resource-group riddhi_rg3 --name recordtype-FlowLog --vnet vnet-centraluseuap --storage-account riddhicentraluseuap --record-types "B,E"az network watcher flow-log show --location centraluseuap --name recordtype-FlowLogaz network watcher flow-log update --location centraluseuap --resource-group riddhi_rg3 --name recordtype-FlowLog --vnet vnet-centraluseuap --storage-account riddhicentraluseuap --record-types "B,C"History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.