[Network] az network virtual-appliance: Add --nva-interface-configurations parameter
#32470
Conversation
huiii99
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network virtual-appliance create | cmd network virtual-appliance create added parameter nva_interface_configurations |
||
| network virtual-appliance create | cmd network virtual-appliance create update parameter internet_ingress_public_ips: updated property name from internet_ingress_public_ips to internet_ingress_ips |
||
| network virtual-appliance identity | sub group network virtual-appliance identity added |
||
| network virtual-appliance update | cmd network virtual-appliance update added parameter nva_interface_configurations |
||
| network virtual-appliance update | cmd network virtual-appliance update update parameter internet_ingress_public_ips: updated property name from internet_ingress_public_ips to internet_ingress_ips |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for NvaInterfaceConfiguration in the network virtual-appliance command group, enabling deployment of Network Virtual Appliances (NVAs) in Virtual Networks using interface configurations. The changes include:
- Introduction of the
--interface-configparameter for create and update commands - Update to API version 2024-10-01 from 2023-11-01
- Addition of identity management subcommands (assign, remove, show, wait)
- New test scenario for VNet-based NVA deployment with interface configurations
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test_network_commands.py | Adds comprehensive test for NVA VNet deployment with interface configurations, including provisioning checks and retry logic |
| nva-interface-config-example.json | Provides example JSON structure for interface configuration with two NICs (private and public) |
| identity/* (5 files) | Auto-generated AAZ files for new identity management subcommands |
| _create.py, _update.py, _show.py, _list.py, _wait.py, _delete.py, _reimage.py | Updated to API version 2024-10-01 with schema changes for nvaInterfaceConfigurations |
| _help.py | Adds help documentation for the create command with interface-config parameter examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/_create.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Show resolved
Hide resolved
...azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/_reimage.py
Outdated
Show resolved
Hide resolved
|
for the "single" feature request, we don't need to modify but instead use the pull request title to represent the changelog. |
this breaking-changes checking tool is very important for ensuring the quality of our pull requests. we need to make sure there are no breaking changes whenever possible, unless we intentionally decide to introduce them. |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/_create.py
Outdated
Show resolved
Hide resolved
necusjz
changed the title
az network virtual-appliance: Add --nva-interface-configurations parameter
huiii99
requested review from
calvinhzy,
evelyn-ys and
yanzhudd
as code owners
huiii99
force-pushed
the
network-nva-vnet-support
branch
from
a4fa492 to
6349d7b
Compare
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
3 participants
Related command
az network virtual-appliance createaz network virtual-appliance updateaz network virtual-appliance showDescription
Add support for NvaInterfaceConfiguration in network virtual-appliance command group.
Resolve #32413
aaz Azure/aaz#907
Testing Guide
azdev test NetworkVirtualApplianceVnetScenarioTest --live --discoverazdev test NetworkVirtualApplianceVnetScenarioTestHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.