Skip to content

Conversation

Copy link

Copilot AI commented Sep 23, 2025

This PR implements comprehensive support for Kubernetes version 1.33.5 in aks-engine-azurestack, following the structured implementation process for adding new Kubernetes versions.

Changes Made

Version Support Configuration

  • Added 1.33.5 as a supported version in all Kubernetes version maps (AllKubernetesSupportedVersions, AllKubernetesSupportedVersionsAzureStack, AllKubernetesWindowsSupportedVersionsAzureStack)
  • Deprecated 1.30.14 to maintain only the latest two minor versions (1.31 and 1.33) as creatable
  • Updated default release constants to 1.32 (second-to-last minor version)

Feature Gate Cleanup

Added version guards for Kubernetes 1.33.0+ to remove 16 deprecated feature gates across all component defaults:

  • AdmissionWebhookMatchConditions, AggregatedDiscoveryEndpoint, APIListChunking, AppArmor, AppArmorFields
  • CPUManager, DisableCloudProviders, DisableKubeletCloudCredentialProviders, EfficientWatchResumption
  • JobPodFailurePolicy, KubeProxyDrainingTerminatingNodes, PDBUnhealthyPodEvictionPolicy
  • PersistentVolumeLastPhaseTransitionTime, RemainingItemCount, VolumeCapacityPriority, WatchBookmark

CSI and Ancillary Component Updates

Updated container image versions for Kubernetes 1.33 support:

  • CSI Components: provisioner v5.3.0, attacher v4.9.0, livenessprobe v2.16.0, node-driver-registrar v2.14.0, snapshotter v8.3.0, snapshot-controller v8.3.0, resizer v1.14.0, azuredisk-csi v1.33.4
  • Ancillary Components: addon-resizer 1.8.23, metrics-server v0.8.0, kube-addon-manager v9.1.8, cluster-autoscaler v1.33.1
  • Azure Cloud Managers: cloud-controller-manager v1.33.1, cloud-node-manager v1.33.0

VHD Build Script Updates

  • Linux VHD: Updated all component version arrays in install-dependencies.sh with versions extracted from supported Kubernetes releases
  • Windows VHD: Updated container image lists and Kubernetes binary download URLs in both main and phase2 scripts for Windows Server 2019 support

Configuration and Test Updates

  • Updated Azure Stack example configurations to use Kubernetes v1.31.11 (second-to-last supported version)
  • Updated kubectl version in hack/tools/Makefile to v1.31.11
  • Created new release example API model for Kubernetes 1.33
  • Updated generate test examples to include comprehensive testing for supported versions 1.33 and 1.31

Testing

Added comprehensive unit tests for feature gate removal functionality across all five component defaults files (kubelet, apiserver, controller-manager, cloud-controller-manager, scheduler), following existing test patterns to ensure proper validation.

All changes maintain backward compatibility and follow established repository patterns and conventions.

Fixes #355.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copy link
Author

Copilot AI commented Sep 23, 2025

@haofan-ms 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI and others added 7 commits September 23, 2025 18:07
Co-authored-by: haofan-ms <56602314+haofan-ms@users.noreply.github.com>
Co-authored-by: haofan-ms <56602314+haofan-ms@users.noreply.github.com>
Co-authored-by: haofan-ms <56602314+haofan-ms@users.noreply.github.com>
Co-authored-by: haofan-ms <56602314+haofan-ms@users.noreply.github.com>
Co-authored-by: haofan-ms <56602314+haofan-ms@users.noreply.github.com>
Co-authored-by: haofan-ms <56602314+haofan-ms@users.noreply.github.com>
Co-authored-by: haofan-ms <56602314+haofan-ms@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Support for Kubernetes Version 1.33.5 Add Support for Kubernetes Version 1.33.5 Sep 23, 2025
Copilot AI requested a review from haofan-ms September 23, 2025 18:36
@haofan-ms haofan-ms changed the title Add Support for Kubernetes Version 1.33.5 [DNM] Add Support for Kubernetes Version 1.33.5 Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for Kubernetes Version 1.33.5

2 participants