Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Conversation

@seanknox
Copy link
Contributor

@seanknox seanknox commented Aug 1, 2017

What this PR does / why we need it:

  • Fix file permissions on vendor/ (I think this might be a Windows vs UNIX thing that snuck in via First round of i18n in acs-engine based on gettext. Subsequent change… #627)
  • Add github.com/JiangtianLi/gettext as a dependency of the project and remove from Dockerfile
  • Change all third-party dependencies from "^" (automatic minor version bumps) to
    hardcoded versions which require explicit version changes in glide.yaml. This is because we (Microsoft) need to re-register every OSS version we use, even if the project at a certain point of time was approved by MSFT OSS.
  • Allow patch level upgrades ("~") of github.com/Azure/go-autorest and
    github.com/Azure/azure-sdk-for-go
  • Bump github.com/Azure/go-autorest from v8.1.0 to v8.1.1
  • Bump github.com/Azure/azure-sdk-for-go from v10.1.0-beta to v10.1.1-beta
  • Running glide update is now a lot safer.

This change is Reviewable

Sean Knox added 2 commits July 31, 2017 17:23
- Add github.com/JiangtianLi/gettext as a dependency of the project
- Change all third-party dependencies from "^" (automatic minor bumps) to
hardcoded versions which require explicit version changes in glide.yaml.
This is because we (Microsoft) need to re-register every OSS version we
use, even if the project at a certain point of time was approved by MSFT
OSS.
- Allow patch level upgrades of github.com/Azure/go-autorest and
github.com/Azure/azure-sdk-for-go
- Bump github.com/Azure/go-autorest from v8.1.0 to v8.1.1
- Bump github.com/Azure/azure-sdk-for-go from v10.1.0-beta to v10.1.1-beta
- Running `glide update` is now a lot safer.
Copy link
Contributor

@JiangtianLi JiangtianLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanknox seanknox merged commit dc1854d into master Aug 1, 2017
@ghost ghost removed the in progress label Aug 1, 2017
@seanknox seanknox deleted the gettext-to-glide branch August 1, 2017 02:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants