Improve pscloud pool CLI definitions

Commands/pscloud/pool/_create.md

@@ -12,5 +12,5 @@ Create a storage pool
 
 - StoragePools_Create
     ```bash
-        pscloud pool create --resource-group rgpurestorage --storage-pool-name storagePoolname --availability-zone vknyl --vnet-injection "{subnet-id:tnlctolrxdvnkjiphlrdxq,vnet-id:zbumtytyqwewjcyckwqchiypshv}" --provisioned-bandwidth 17 --reservation-id xiowoxnbtcotutcmmrofvgdi --type None --user-assigned-identities "{key4211:{}}" --tags "{key7593:vsyiygyurvwlfaezpuqu}" --location lonlc
+        pscloud pool create --resource-group rgpurestorage --storage-pool-name storagePoolname --zone 1 --subnet-id /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{vnetName}/subnets/{subnetName} --vnet-id /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{vnetName} --provisioned-bandwidth 100 --reservation-id /subscriptions/{subscriptionId}/providers/PureStorage.Block/reservations/{reservationName} --location eastus
     ```

Resources/mgmt-plane/L3N1YnNjcmlwdGlvbnMve30vcmVzb3VyY2Vncm91cHMve30vcHJvdmlkZXJzL3B1cmVzdG9yYWdlLmJsb2NrL3N0b3JhZ2Vwb29scy97fQ==/2024-11-01.xml

@@ -190,53 +190,16 @@
         </arg>
         <arg type="SubscriptionId" var="$Path.subscriptionId" options="subscription" required="True" idPart="subscription"/>
       </argGroup>
-      <argGroup name="Identity">
-        <arg type="string" var="$resource.identity.systemAssigned" options="mi-system-assigned system-assigned" group="Identity">
-          <blank value="&quot;True&quot;"/>
-          <help short="Set the system managed identity."/>
-        </arg>
-        <arg type="string" var="$resource.identity.type" options="type" hide="True" group="Identity">
-          <help short="Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed)."/>
-          <enum>
-            <item name="None" value="&quot;None&quot;"/>
-            <item name="SystemAssigned" value="&quot;SystemAssigned&quot;"/>
-            <item name="SystemAssigned,UserAssigned" value="&quot;SystemAssigned,UserAssigned&quot;"/>
-            <item name="UserAssigned" value="&quot;UserAssigned&quot;"/>
-          </enum>
-        </arg>
-        <arg type="array<string>" var="$resource.identity.userAssigned" options="mi-user-assigned user-assigned" group="Identity">
-          <blank value="[]"/>
-          <help short="Set the user managed identities."/>
-          <item type="string"/>
-        </arg>
-        <arg type="object" var="$resource.identity.userAssignedIdentities" options="user-assigned-identities" hide="True" group="Identity">
-          <help short="The set of user assigned identities associated with the resource. The userAssignedIdentities dictionary keys will be ARM resource ids in the form: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{identityName}. The dictionary values can be empty objects ({}) in requests."/>
-          <additionalProp>
-            <item nullable="True" type="object">
-              <blank value="{}"/>
-            </item>
-          </additionalProp>
-        </arg>
-      </argGroup>
       <argGroup name="Properties">
-        <arg type="string" var="$resource.properties.availabilityZone" options="availability-zone" group="Properties">
+        <arg type="string" var="$resource.properties.availabilityZone" options="zone z" required="True" group="Properties">
           <help short="Azure Availability Zone the Pool is located in"/>
         </arg>
-        <arg type="integer64" var="$resource.properties.provisionedBandwidthMbPerSec" options="provisioned-bandwidth" group="Properties">
+        <arg type="integer64" var="$resource.properties.provisionedBandwidthMbPerSec" options="provisioned-bandwidth" required="True" group="Properties">
           <help short="Total bandwidth provisioned for the pool, in MB/s"/>
         </arg>
-        <arg type="string" var="$resource.properties.reservationResourceId" options="reservation-id" group="Properties">
+        <arg type="string" var="$resource.properties.reservationResourceId" options="reservation-id" required="True" group="Properties">
           <help short="Azure resource ID of the Pure Storage Cloud service (reservation resource) this storage pool belongs to"/>
         </arg>
-        <arg type="object" var="$resource.properties.vnetInjection" options="vnet-injection" group="Properties">
-          <help short="Network properties of the storage pool"/>
-          <arg type="string" var="$resource.properties.vnetInjection.subnetId" options="subnet-id" required="True">
-            <help short="Azure resource ID of the Virtual Network subnet where the storage pool will be connected"/>
-          </arg>
-          <arg type="string" var="$resource.properties.vnetInjection.vnetId" options="vnet-id" required="True">
-            <help short="Azure resource ID of the Virtual Network in which the subnet is located"/>
-          </arg>
-        </arg>
       </argGroup>
       <argGroup name="Resource">
         <arg type="ResourceLocation" var="$resource.location" options="location l" required="True" group="Resource">
@@ -249,6 +212,14 @@
           </additionalProp>
         </arg>
       </argGroup>
+      <argGroup name="VnetInjection">
+        <arg type="string" var="$resource.properties.vnetInjection.subnetId" options="subnet-id" required="True" group="VnetInjection">
+          <help short="Azure resource ID of the Virtual Network subnet where the storage pool will be connected"/>
+        </arg>
+        <arg type="string" var="$resource.properties.vnetInjection.vnetId" options="vnet-id" required="True" group="VnetInjection">
+          <help short="Azure resource ID of the Virtual Network in which the subnet is located"/>
+        </arg>
+      </argGroup>
       <operation operationId="StoragePools_Create">
         <longRunning finalStateVia="azure-async-operation"/>
         <http path="/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/PureStorage.Block/storagePools/{storagePoolName}">
@@ -271,31 +242,12 @@
             <body>
               <json>
                 <schema type="object" name="resource" required="True" clientFlatten="True">
-                  <prop type="IdentityObject" name="identity">
-                    <prop type="string" name="type" arg="$resource.identity.type" required="True">
-                      <enum>
-                        <item value="&quot;None&quot;"/>
-                        <item value="&quot;SystemAssigned&quot;"/>
-                        <item value="&quot;SystemAssigned,UserAssigned&quot;"/>
-                        <item value="&quot;UserAssigned&quot;"/>
-                      </enum>
-                    </prop>
-                    <prop type="object" name="userAssignedIdentities" arg="$resource.identity.userAssignedIdentities">
-                      <additionalProp>
-                        <item nullable="True" type="object"/>
-                      </additionalProp>
-                    </prop>
-                    <userAssigned action="create" type="array<string>" name="userAssigned" arg="$resource.identity.userAssigned">
-                      <item action="create" type="string"/>
-                    </userAssigned>
-                    <systemAssigned action="create" type="string" name="systemAssigned" arg="$resource.identity.systemAssigned"/>
-                  </prop>
                   <prop type="ResourceLocation" name="location" arg="$resource.location" required="True"/>
                   <prop type="object" name="properties" clientFlatten="True">
                     <prop type="string" name="availabilityZone" arg="$resource.properties.availabilityZone" required="True"/>
                     <prop type="integer64" name="provisionedBandwidthMbPerSec" arg="$resource.properties.provisionedBandwidthMbPerSec" required="True"/>
                     <prop type="string" name="reservationResourceId" arg="$resource.properties.reservationResourceId" required="True"/>
-                    <prop type="object" name="vnetInjection" arg="$resource.properties.vnetInjection" required="True">
+                    <prop type="object" name="vnetInjection" required="True">
                       <prop type="string" name="subnetId" arg="$resource.properties.vnetInjection.subnetId" required="True"/>
                       <prop type="string" name="vnetId" arg="$resource.properties.vnetInjection.vnetId" required="True"/>
                     </prop>
@@ -420,34 +372,6 @@
         </arg>
         <arg type="SubscriptionId" var="$Path.subscriptionId" options="subscription" required="True" idPart="subscription"/>
       </argGroup>
-      <argGroup name="Identity">
-        <arg type="string" var="$properties.identity.systemAssigned" options="mi-system-assigned system-assigned" group="Identity">
-          <blank value="&quot;True&quot;"/>
-          <help short="Set the system managed identity."/>
-        </arg>
-        <arg type="string" var="$properties.identity.type" options="type" hide="True" group="Identity">
-          <help short="Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed)."/>
-          <enum>
-            <item name="None" value="&quot;None&quot;"/>
-            <item name="SystemAssigned" value="&quot;SystemAssigned&quot;"/>
-            <item name="SystemAssigned,UserAssigned" value="&quot;SystemAssigned,UserAssigned&quot;"/>
-            <item name="UserAssigned" value="&quot;UserAssigned&quot;"/>
-          </enum>
-        </arg>
-        <arg type="array<string>" var="$properties.identity.userAssigned" options="mi-user-assigned user-assigned" group="Identity">
-          <blank value="[]"/>
-          <help short="Set the user managed identities."/>
-          <item type="string"/>
-        </arg>
-        <arg type="object" var="$properties.identity.userAssignedIdentities" options="user-assigned-identities" hide="True" group="Identity">
-          <help short="The set of user assigned identities associated with the resource. The userAssignedIdentities dictionary keys will be ARM resource ids in the form: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{identityName}. The dictionary values can be empty objects ({}) in requests."/>
-          <additionalProp>
-            <item nullable="True" type="object">
-              <blank value="{}"/>
-            </item>
-          </additionalProp>
-        </arg>
-      </argGroup>
       <argGroup name="Properties">
         <arg type="integer64" var="$properties.properties.provisionedBandwidthMbPerSec" options="provisioned-bandwidth" group="Properties">
           <help short="Total bandwidth provisioned for the pool, in MB/s"/>
@@ -481,25 +405,6 @@
             <body>
               <json>
                 <schema type="object" name="properties" required="True" clientFlatten="True">
-                  <prop type="IdentityObject" name="identity">
-                    <prop type="string" name="type" arg="$properties.identity.type" required="True">
-                      <enum>
-                        <item value="&quot;None&quot;"/>
-                        <item value="&quot;SystemAssigned&quot;"/>
-                        <item value="&quot;SystemAssigned,UserAssigned&quot;"/>
-                        <item value="&quot;UserAssigned&quot;"/>
-                      </enum>
-                    </prop>
-                    <prop type="object" name="userAssignedIdentities" arg="$properties.identity.userAssignedIdentities">
-                      <additionalProp>
-                        <item nullable="True" type="object"/>
-                      </additionalProp>
-                    </prop>
-                    <userAssigned action="create" type="array<string>" name="userAssigned" arg="$properties.identity.userAssigned">
-                      <item action="create" type="string"/>
-                    </userAssigned>
-                    <systemAssigned action="create" type="string" name="systemAssigned" arg="$properties.identity.systemAssigned"/>
-                  </prop>
                   <prop type="object" name="properties" clientFlatten="True">
                     <prop type="integer64" name="provisionedBandwidthMbPerSec" arg="$properties.properties.provisionedBandwidthMbPerSec"/>
                   </prop>

Resources/mgmt-plane/L3N1YnNjcmlwdGlvbnMve30vcmVzb3VyY2Vncm91cHMve30vcHJvdmlkZXJzL3B1cmVzdG9yYWdlLmJsb2NrL3N0b3JhZ2Vwb29scy97fS9nZXRhdnNzdGF0dXM=/2024-11-01.json

@@ -1 +1 @@
-{"plane": "mgmt-plane", "resources": [{"id": "/subscriptions/{}/resourcegroups/{}/providers/purestorage.block/storagepools/{}/getavsstatus", "version": "2024-11-01", "swagger": "mgmt-plane/purestorage/ResourceProviders/PureStorage.Block/Paths/L3N1YnNjcmlwdGlvbnMve3N1YnNjcmlwdGlvbklkfS9yZXNvdXJjZUdyb3Vwcy97cmVzb3VyY2VHcm91cE5hbWV9L3Byb3ZpZGVycy9QdXJlU3RvcmFnZS5CbG9jay9zdG9yYWdlUG9vbHMve3N0b3JhZ2VQb29sTmFtZX0vZ2V0QXZzU3RhdHVz/V/MjAyNC0xMS0wMQ=="}], "commandGroups": [{"name": "pscloud pool", "commands": [{"name": "get-avs-status", "version": "2024-11-01", "resources": [{"id": "/subscriptions/{}/resourcegroups/{}/providers/purestorage.block/storagepools/{}/getavsstatus", "version": "2024-11-01", "swagger": "mgmt-plane/purestorage/ResourceProviders/PureStorage.Block/Paths/L3N1YnNjcmlwdGlvbnMve3N1YnNjcmlwdGlvbklkfS9yZXNvdXJjZUdyb3Vwcy97cmVzb3VyY2VHcm91cE5hbWV9L3Byb3ZpZGVycy9QdXJlU3RvcmFnZS5CbG9jay9zdG9yYWdlUG9vbHMve3N0b3JhZ2VQb29sTmFtZX0vZ2V0QXZzU3RhdHVz/V/MjAyNC0xMS0wMQ=="}], "argGroups": [{"name": "", "args": [{"type": "ResourceGroupName", "var": "$Path.resourceGroupName", "options": ["g", "resource-group"], "required": true, "idPart": "resource_group"}, {"type": "string", "var": "$Path.storagePoolName", "options": ["storage-pool-name"], "required": true, "idPart": "name", "help": {"short": "Name of the storage pool"}, "format": {"pattern": "^[a-zA-Z0-9\\-_]{1,127}$", "maxLength": 127, "minLength": 1}}, {"type": "SubscriptionId", "var": "$Path.subscriptionId", "options": ["subscription"], "required": true, "idPart": "subscription"}]}], "operations": [{"operationId": "StoragePools_GetAvsStatus", "http": {"path": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/PureStorage.Block/storagePools/{storagePoolName}/getAvsStatus", "request": {"method": "post", "path": {"params": [{"type": "string", "name": "resourceGroupName", "arg": "$Path.resourceGroupName", "required": true, "format": {"maxLength": 90, "minLength": 1}}, {"type": "string", "name": "storagePoolName", "arg": "$Path.storagePoolName", "required": true, "format": {"pattern": "^[a-zA-Z0-9\\-_]{1,127}$", "maxLength": 127, "minLength": 1}}, {"type": "uuid", "name": "subscriptionId", "arg": "$Path.subscriptionId", "required": true}]}, "query": {"consts": [{"readOnly": true, "const": true, "default": {"value": "2024-11-01"}, "type": "string", "name": "api-version", "required": true, "format": {"minLength": 1}}]}}, "responses": [{"statusCode": [200], "body": {"json": {"var": "$Instance", "schema": {"type": "object", "props": [{"type": "boolean", "name": "avsEnabled", "required": true}, {"type": "string", "name": "currentConnectionStatus", "required": true}, {"type": "string", "name": "sddcResourceId"}]}}}}, {"isError": true, "body": {"json": {"schema": {"type": "@MgmtErrorFormat"}}}}]}}], "outputs": [{"type": "object", "ref": "$Instance", "clientFlatten": true}]}]}]}
+{"plane": "mgmt-plane", "resources": [{"id": "/subscriptions/{}/resourcegroups/{}/providers/purestorage.block/storagepools/{}/getavsstatus", "version": "2024-11-01", "swagger": "mgmt-plane/purestorage/ResourceProviders/PureStorage.Block/Paths/L3N1YnNjcmlwdGlvbnMve3N1YnNjcmlwdGlvbklkfS9yZXNvdXJjZUdyb3Vwcy97cmVzb3VyY2VHcm91cE5hbWV9L3Byb3ZpZGVycy9QdXJlU3RvcmFnZS5CbG9jay9zdG9yYWdlUG9vbHMve3N0b3JhZ2VQb29sTmFtZX0vZ2V0QXZzU3RhdHVz/V/MjAyNC0xMS0wMQ=="}], "commandGroups": [{"name": "pscloud pool", "commands": [{"name": "get-avs-status", "version": "2024-11-01", "resources": [{"id": "/subscriptions/{}/resourcegroups/{}/providers/purestorage.block/storagepools/{}/getavsstatus", "version": "2024-11-01", "swagger": "mgmt-plane/purestorage/ResourceProviders/PureStorage.Block/Paths/L3N1YnNjcmlwdGlvbnMve3N1YnNjcmlwdGlvbklkfS9yZXNvdXJjZUdyb3Vwcy97cmVzb3VyY2VHcm91cE5hbWV9L3Byb3ZpZGVycy9QdXJlU3RvcmFnZS5CbG9jay9zdG9yYWdlUG9vbHMve3N0b3JhZ2VQb29sTmFtZX0vZ2V0QXZzU3RhdHVz/V/MjAyNC0xMS0wMQ=="}], "argGroups": [{"name": "", "args": [{"type": "ResourceGroupName", "var": "$Path.resourceGroupName", "options": ["g", "resource-group"], "required": true, "idPart": "resource_group"}, {"type": "string", "var": "$Path.storagePoolName", "options": ["n", "name"], "required": true, "group": "", "idPart": "name", "help": {"short": "Name of the storage pool"}, "format": {"pattern": "^[a-zA-Z0-9\\-_]{1,127}$", "maxLength": 127, "minLength": 1}}, {"type": "SubscriptionId", "var": "$Path.subscriptionId", "options": ["subscription"], "required": true, "idPart": "subscription"}]}], "operations": [{"operationId": "StoragePools_GetAvsStatus", "http": {"path": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/PureStorage.Block/storagePools/{storagePoolName}/getAvsStatus", "request": {"method": "post", "path": {"params": [{"type": "string", "name": "resourceGroupName", "arg": "$Path.resourceGroupName", "required": true, "format": {"maxLength": 90, "minLength": 1}}, {"type": "string", "name": "storagePoolName", "arg": "$Path.storagePoolName", "required": true, "format": {"pattern": "^[a-zA-Z0-9\\-_]{1,127}$", "maxLength": 127, "minLength": 1}}, {"type": "uuid", "name": "subscriptionId", "arg": "$Path.subscriptionId", "required": true}]}, "query": {"consts": [{"readOnly": true, "const": true, "default": {"value": "2024-11-01"}, "type": "string", "name": "api-version", "required": true, "format": {"minLength": 1}}]}}, "responses": [{"statusCode": [200], "body": {"json": {"var": "$Instance", "schema": {"type": "object", "props": [{"type": "boolean", "name": "avsEnabled", "required": true}, {"type": "string", "name": "currentConnectionStatus", "required": true}, {"type": "string", "name": "sddcResourceId"}]}}}}, {"isError": true, "body": {"json": {"schema": {"type": "@MgmtErrorFormat"}}}}]}}], "outputs": [{"type": "object", "ref": "$Instance", "clientFlatten": true}]}]}]}

Resources/mgmt-plane/L3N1YnNjcmlwdGlvbnMve30vcmVzb3VyY2Vncm91cHMve30vcHJvdmlkZXJzL3B1cmVzdG9yYWdlLmJsb2NrL3N0b3JhZ2Vwb29scy97fS9nZXRhdnNzdGF0dXM=/2024-11-01.xml

@@ -6,7 +6,7 @@
       <resource id="/subscriptions/{}/resourcegroups/{}/providers/purestorage.block/storagepools/{}/getavsstatus" version="2024-11-01" swagger="mgmt-plane/purestorage/ResourceProviders/PureStorage.Block/Paths/L3N1YnNjcmlwdGlvbnMve3N1YnNjcmlwdGlvbklkfS9yZXNvdXJjZUdyb3Vwcy97cmVzb3VyY2VHcm91cE5hbWV9L3Byb3ZpZGVycy9QdXJlU3RvcmFnZS5CbG9jay9zdG9yYWdlUG9vbHMve3N0b3JhZ2VQb29sTmFtZX0vZ2V0QXZzU3RhdHVz/V/MjAyNC0xMS0wMQ=="/>
       <argGroup name="">
         <arg type="ResourceGroupName" var="$Path.resourceGroupName" options="resource-group g" required="True" idPart="resource_group"/>
-        <arg type="string" var="$Path.storagePoolName" options="storage-pool-name" required="True" idPart="name">
+        <arg type="string" var="$Path.storagePoolName" options="name n" required="True" group="" idPart="name">
           <help short="Name of the storage pool"/>
           <format pattern="^[a-zA-Z0-9\-_]{1,127}$" maxLength="127" minLength="1"/>
         </arg>