Skip to content

fix for tokenProviderCheck #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishpandey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix for tokenProviderCheck #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions src/handler/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,25 +158,27 @@ func (handler *Handler) ReadinessCheck(w http.ResponseWriter, r *http.Request) {
// If token provider is not instantiated, cannot fetch token, so fail request
func (handler *Handler) checkTokenProvider(ctx context.Context) error {
if handler.tokenProvider == nil {
token, err := handler.tokenProvider.GetAccessToken()
if len(token) == 0 || err != nil {
// Start tracing
_, span := otel.Tracer(constants.SERVICE_TELEMETRY_KEY).Start(ctx, "checkTokenProvider")
defer span.End()

// If we run into a case where we received empty token without any errors
if err == nil {
err = errors.New("handler, tokenProvider is not instantiated, cannot forward request")
}
return errors.New("handler, tokenProvider is not instantiated, cannot forward request")
}

token, err := handler.tokenProvider.GetAccessToken()
if len(token) == 0 || err != nil {
// Start tracing
_, span := otel.Tracer(constants.SERVICE_TELEMETRY_KEY).Start(ctx, "checkTokenProvider")
defer span.End()

// If we run into a case where we received empty token without any errors
if err == nil {
err = errors.New("handler, empty token found, cannot forward request")
}

span.SetAttributes(attribute.Int("proxy.status_code", http.StatusServiceUnavailable))
span.RecordError(err)
span.SetStatus(codes.Error, "failed to forward request")
span.SetAttributes(attribute.Int("proxy.status_code", http.StatusServiceUnavailable))
span.RecordError(err)
span.SetStatus(codes.Error, "failed to forward request")

log.Errorln("failed to forward request", err)
log.Errorln("failed to forward request", err)

return err
}
return err
}

return nil
Expand Down