Parse the ga signatures from the goal state #3519
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddieford
requested review from
ZhidongPeng,
nagworld9 and
narrieta
as code owners
narrieta
reviewed
Dec 23, 2025
| uris_list = find(ga_family, "Uris") | ||
| uris = findall(uris_list, "Uri") | ||
| ga_signatures_list = find(ga_family, "VersionToSignatureMappings") | ||
| ga_signature_mappings = findall(ga_signatures_list, "GASignature") |
Member
There was a problem hiding this comment.
What does findall() return if it does not find the element? I could not find this in the documentation and I see some parts of the code that check against None.
| for uri in uris: | ||
| family.uris.append(gettext(uri)) | ||
| for ga_signature_mapping in ga_signature_mappings: | ||
| ga_signature_version = findtext(ga_signature_mapping, "Version") |
| for ga_signature_mapping in ga_signature_mappings: | ||
| ga_signature_version = ga_signature_mapping.get("version") | ||
| ga_encoded_signature = ga_signature_mapping.get("encodedSignature") | ||
| agent_family.ga_version_to_signature_mapping[ga_signature_version] = ga_encoded_signature |
Member
There was a problem hiding this comment.
do we need to check against None?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #
PR information
developbranch.Quality of Code and Contribution Guidelines
Distro maintenance information, if applicable