Skip to content

Use nmcli to set DHCP hostname for modern RHEL distros #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vittyvk wants to merge 1 commit into
base: develop
Choose a base branch
from
+30 −6
Open

Use nmcli to set DHCP hostname for modern RHEL distros #3243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions azurelinuxagent/common/osutil/redhat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,33 @@ def check_and_recover_nic_state(self, ifname):
# TODO: Implement and test a way to recover the network interface for RedhatOSModernUtil
pass

def publish_hostname(self, hostname, recover_nic=False):
# RedhatOSUtil was updated to conditionally run NetworkManager restart in response to a race condition between
# NetworkManager restart and the agent restarting the network interface during publish_hostname. Keeping the
# NetworkManager restart in RedhatOSModernUtil because the issue was not reproduced on these versions.
shellutil.run("service NetworkManager restart")
DefaultOSUtil.publish_hostname(self, hostname)
def set_dhcp_hostname(self, hostname):
"""
RHEL8+ distributions use NetworkManager to configure network interfaces, set DHCP hostname
in NM device and connection settings.
"""
ifname = self.get_if_name()
retry_limit = 4
wait = 5

ret, con = shellutil.run_get_output("nmcli -g GENERAL.CONNECTION device show '{0}'".format(ifname))
if ret != 0:
logger.error("failed to get NetworkManager connection for {0}: return code {1}".format(ifname, ret))
return
else:
con = con.split('\n')[0]
logger.verbose("Using NetworkManager connection '{0}' for {1}".format(con, ifname))

ret = shellutil.run("nmcli connection modify '{0}' ipv4.dhcp-hostname '{1}' ipv6.dhcp-hostname '{1}'".format(con, hostname))
if ret != 0:
logger.error("failed to persist DHCP hostname for interface {0}: return code {1}".format(ifname, ret))

for attempt in range(1, retry_limit):
ret = shellutil.run("nmcli device modify '{0}' ipv4.dhcp-hostname '{1}' ipv6.dhcp-hostname '{1}'".format(ifname, hostname))
if ret == 0:
return
logger.warn("failed to modify DHCP hostname for interface {0}: return code {1}".format(ifname, ret))
logger.info("retrying in {0} seconds".format(wait))
time.sleep(wait)

logger.error("failed to modify DHCP hostname for interface {0}: no more tries".format(ifname))