Draft
Conversation
* Changed -replace to .Replace() to avoid regexp issues * Save replacement result instead of returning it to host
* Removed no-op and extra replacements * Added TODOs
Prettytaryn23
approved these changes
Feb 22, 2025
Prettytaryn23
approved these changes
Feb 22, 2025
| #$readmeRaw = $readmeRaw.Replace('# Azure Governance Visualizer aka AzGovViz', "[](https://scorecard.dev/viewer/?uri=github.com/Azure/Azure-Governance-Visualizer)`n`n# Azure Governance Visualizer aka AzGovViz") | ||
|
|
||
| $readmeRaw | Set-Content 'README.md' | ||
| Write-Host 'README.md has been updated with block for upstream notice.' |
Author
There was a problem hiding this comment.
Unblock as remove commented code that
- does nothing
- creates duplicate OpenSSF badge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script did not save content changes into README.md because of the minor issues.
Running the script with proposed changes has following output with git diff:
Note that OpenSSF URL changes are not visible because
jacobtomlinson/gha-find-replace@v3does the replacement