Skip to content

Fix: Fixing parameters capital letters.#159

Merged
mosabami merged 3 commits intoAzure:mainfrom
tanure:main
Apr 15, 2025
Merged

Fix: Fixing parameters capital letters.#159
mosabami merged 3 commits intoAzure:mainfrom
tanure:main

Conversation

@tanure
Copy link
Contributor

@tanure tanure commented Nov 22, 2024

This pull request includes a small change to the Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/03-Network-Hub/parameters-main.json file. The change standardizes the naming convention for several parameters by converting them to camelCase. This change fix issues during the pipeline execution where some parameters are not found, even if the parameter file is defined.

  • Standardized parameter names to camelCase in parameters-main.json

@tanure
Copy link
Contributor Author

tanure commented Nov 25, 2024

Updating the Github actions deploy-infrastructure
This pull request includes changes to the deployment infrastructure and parameter naming conventions to improve consistency and remove unnecessary steps. The most important changes include removing the creation of a User Defined Route and standardizing parameter names in the network configuration files. The following files doesn't exist on the directory:

  • ${{ env.BICEP_ROOT_PATH }}03-Network-Hub/updateUDR.bicep
  • ${{ env.BICEP_ROOT_PATH }}03-Network-Hub/parameters-updateUDR.json

Apparently the UDR is creating inside the main.bicep file. The pipeline fails because of the missing files.

Changes to deployment infrastructure:

Parameter naming standardization:

@mosabami mosabami merged commit 7e2983b into Azure:main Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants