Skip to content

docs: improved comments for generate-variants.js #19980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AztecBot merged 1 commit into from
Jan 27, 2026
Merged

docs: improved comments for generate-variants.js #19980

AztecBot merged 1 commit into from
Jan 27, 2026
+270 −24

Conversation

@iAmMichaelConnor
Copy link
Contributor

@iAmMichaelConnor iAmMichaelConnor commented Jan 27, 2026

I asked claude about this file many many days ago. It wrote some comments and conjured some tests (albeit not using jest)

@AztecBot
Copy link
Collaborator

AztecBot commented Jan 27, 2026 •
edited
Loading

Flakey Tests

🤖 says: This CI run detected 3 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/c938d99f55ef3097�c938d99f55ef30978;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_first_slot.test.ts (226s) (code: 1) group:e2e-p2p-epoch-flakes (\033Aztec Bot\033: docs: improved comments for generate-variants.js (#19980))
\033FLAKED\033 (8;;http://ci.aztec-labs.com/599dc4c27005ece8�599dc4c27005ece88;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_high_tps_block_building.test.ts (277s) (code: 1) group:e2e-p2p-epoch-flakes (\033Aztec Bot\033: docs: improved comments for generate-variants.js (#19980))
\033FLAKED\033 (8;;http://ci.aztec-labs.com/ab446a6367715353�ab446a63677153538;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/valid_epoch_pruned_slash.test.ts (404s) (code: 1) group:e2e-p2p-epoch-flakes (\033Aztec Bot\033: docs: improved comments for generate-variants.js (#19980))

@iAmMichaelConnor
docs: improved comments for generate-variants.js
8522902 
I asked claude about this file many many days ago. It wrote some comments and conjured some tests (albeit not using jest)
@AztecBot AztecBot force-pushed the mc/generate-variants branch from 7c94460 to 8522902 Compare January 27, 2026 20:02
@AztecBot AztecBot enabled auto-merge January 27, 2026 20:02
LeilaWang
LeilaWang reviewed Jan 27, 2026
View reviewed changes
noir-projects/noir-protocol-circuits/scripts/generate_variants.js
// CLI args provided - parse them as aliases or tag strings (e.g., "tiny" or "32_4_32_4_4_4_4_4_4")
return allowedVariants
.map((name) => aliases[name] || allowedVariants.split("_").map((v) => +v))
.map((name) => aliases[name] || name.split("_").map((v) => +v))
Copy link
Contributor

@LeilaWang LeilaWang Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice it was broken before 😬

@AztecBot AztecBot added this pull request to the merge queue Jan 27, 2026
Merged via the queue into next with commit 2917078 Jan 27, 2026
17 checks passed
@AztecBot AztecBot deleted the mc/generate-variants branch January 27, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeilaWang LeilaWang LeilaWang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iAmMichaelConnor @AztecBot @LeilaWang