exported all strings to MastodonApi.text so they can be internationalized#4
Open
nicobo wants to merge 1 commit intoAzetJP:masterfrom
Open
exported all strings to MastodonApi.text so they can be internationalized#4nicobo wants to merge 1 commit intoAzetJP:masterfrom
nicobo wants to merge 1 commit intoAzetJP:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use case was to change the title of the widget ("Toots") but this text was mixed with the javascript code.
I've therefore taken out all text strings into the already existing
MastodonApi.textobject.I've updated
mastodon.widget-jp.jsat the same time but left the english text (as it was in the master branch)This is not perfect, but yet a little step towards an easier i18n.