APIGOV-31704 update entitlements endpoint #1001
Draft
+37
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrosca
requested review from
dfeldick,
dgghinea,
jcollins-axway,
sbolosan and
vivekschauhan
as code owners
sbolosan
reviewed
Jan 9, 2026
| if err != nil { | ||
| return nil, err | ||
| } | ||
| entitlements := map[string]interface{}{} |
Collaborator
There was a problem hiding this comment.
Why did this whole section get dropped? This provided expired and false filtering that skipped any entitlement from an expired product and ignored flags that were false or 0. By deleting it, the new implementation returns the map verbatim. Does the endpoint guarantee it only serves up active, true entries? I apologize since I missed the business logic ask. But how are we guarding against disabled entitlements?
Collaborator
There was a problem hiding this comment.
I guess that's why the test for testing expired and false entitlements were removed as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the entitlements endpoint