Hashes FH+TGs together #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For efficiency when transmitting the hash list hashing both the FH and all TGs becomes quite costly. Therefore, one single hash for the entire frame (FH+TGs) is generated. The logic is similar to hashing when a NALU is split into several parts. There is one major difference though, and that is that for FH+TGs it is not known when to complete the ongoing hash until the next frame has been detected. Therefore, a helper function sv_add_ongoing_hash() that handles frame transitions has been added. The commit updates both the signing and the validation side which keeps the test intact.
bjornvolcker
requested review from
Caroline-Holmstrom,
lusikamalo2 and
mithydolphin
as code owners
mithydolphin
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For efficiency when transmitting the hash list hashing both the
FH and all TGs becomes quite costly. Therefore, one single hash
for the entire frame (FH+TGs) is generated.
The logic is similar to hashing when a NALU is split into
several parts. There is one major difference though, and that is
that for FH+TGs it is not known when to complete the ongoing
hash until the next frame has been detected.
Therefore, a helper function sv_add_ongoing_hash() that handles
frame transitions has been added.
The commit updates both the signing and the validation side
which keeps the test intact.