Verifying with SEI returns OK also if SEI is not #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The special case where a partial GOP is successfully validated, but the SEI is not should return success. A failing signature verification could be due to a bit flip of the SEI or a wrongly set Public key. All the content could still be correct for matching the GOP. This is in particular important when the SEI is not in sync.
bjornvolcker
requested review from
Caroline-Holmstrom,
lusikamalo2 and
mithydolphin
as code owners
mithydolphin
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special case where a partial GOP is successfully validated,
but the SEI is not should return success. A failing signature
verification could be due to a bit flip of the SEI or a wrongly
set Public key. All the content could still be correct for
matching the GOP. This is in particular important when the SEI
is not in sync.