Increment of current_partial_gop done outside TLV #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the signing side, the current_partial_gop was updated when encoding the TLVs. The TLV encoding process should not take any actions. It should solely write the current state into the SEI. The update is now done outside encoding. Further, the counter is initialized to -1 instead of 0. This makes it more clear on the validation side when the first SEI is to be used.
bjornvolcker
requested review from
Caroline-Holmstrom,
lusikamalo2 and
mithydolphin
as code owners
mithydolphin
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the signing side, the current_partial_gop was updated
when encoding the TLVs. The TLV encoding process should
not take any actions. It should solely write the current
state into the SEI.
The update is now done outside encoding. Further, the
counter is initialized to -1 instead of 0. This makes
it more clear on the validation side when the first SEI
is to be used.