[DRAFT] tests: initial e2e config and basic testing #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmulraney
reviewed
Feb 20, 2025
| import { AUCTION_TOKEN_ADDRESS } from "../../../../app-config"; | ||
| import { COMPONENTS } from "../constants"; | ||
|
|
||
| const BASE_URL = "http://localhost:5173"; |
Collaborator
There was a problem hiding this comment.
I think this could be the BASE_URL from constants
edmulraney
reviewed
Feb 20, 2025
apps/dapp/cypress/constants.ts
Outdated
| const LAUNCH_ID = | ||
| Cypress.env("VITE_TESTNET") === "true" ? blastSepoliaChainId : baseChainId; | ||
|
|
||
| const APP_BASE_URL = "http://localhost:5173/#"; |
Collaborator
There was a problem hiding this comment.
Isn't the BASE_URL on line 1 this value?
edmulraney
reviewed
Feb 20, 2025
|
|
||
| describe("Auction List Page", () => { | ||
| it("Should load the root page", () => { | ||
| cy.visit(BASE_URL); |
Collaborator
There was a problem hiding this comment.
This will pass even if the home page fails and an error page is shown.
I think we can omit this top level test from here as its covered in the smoke tests:
smoke.cy.ts
it("renders home page", () => {
cy.visit(URLS.HOME);
cy.shouldRenderPageWithId("__AXIS_HOME_PAGE__");
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.