Skip to content

Conversation

@wenfix
Copy link
Collaborator

@wenfix wenfix commented Aug 28, 2024

Closes #218

@wenfix wenfix requested a review from 0xJem August 28, 2024 11:51
Copy link
Contributor

@0xJem 0xJem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but I think you need:

  • Unit tests on prepareBaseDTLParameters()
  • Some validation in prepareBaseDTLParameters() that the basis points values are within range (i.e. throw an error loudly)
  • Document the values sent by form fields into prepareBaseDTLParameters()

@edmulraney
Copy link
Collaborator

@wenfix - probs a good idea to add some unit tests as Jem suggests, as its handling funds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update frontend to support changes to Uniswap DTL callback parameters

4 participants