Fix brightness issues on Laptops #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tness values this is necessary because brightnessctl returns more than one brightness values for some displays fixes part of Axenide#29
|
did you test on some media players are running? does it still dim or not? my PR: |
Author
I think we both fixed different issues, i only encountered the one I am fixing with this pull request,, but i haven't really watched a lot of media on this pc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor brightness_list.sh to use associative array for unique brightness values
this is necessary because without that fix the brightness_list.sh script returns 2 values for the edp-1 for most laptops
fixes part of #29