sync the "attack any" order #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is not a specific comment indicating Attack and Attack Any should be combined, so I'm guessing this was an oversight.
Contributor
Author
|
I've also added a check that the targets of orders are ships. Somehow a checkpoint in Colt's campaign kept triggering this on a target that was not a ship. |
Goober5000
force-pushed
the
saveload_order_enum
branch
from
77b58bc to
4c8cc1c
Compare
Goober5000
added a commit
to Goober5000/fso-scripts
that referenced
this pull request
Aug 19, 2022
There is not a specific comment indicating Attack and Attack Any should be combined, so I'm guessing this was an oversight. I've also added a check that the targets of orders are ships. Somehow a checkpoint in Colt's campaign kept triggering this on a target that was not a ship. This corresponds to the old PR 7: AxemP/AxemFS2Scripts#7
BMagnu
pushed a commit
to FSO-Scripters/fso-scripts
that referenced
this pull request
Aug 19, 2022
There is not a specific comment indicating Attack and Attack Any should be combined, so I'm guessing this was an oversight. I've also added a check that the targets of orders are ships. Somehow a checkpoint in Colt's campaign kept triggering this on a target that was not a ship. This corresponds to the old PR 7: AxemP/AxemFS2Scripts#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not a specific comment indicating Attack and Attack Any should be combined, so I'm guessing this was an oversight.