some scrollwrite changes #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goober5000
force-pushed
the
scrollwrite_sounds
branch
2 times, most recently
from
493d999 to
f54dcb9
Compare
This changes the sound handling so that an in-mission looping sound is played for as long as the text is scrolling, and then stops when the text finishes scrolling. Right now beep_5.wav is used as a placeholder sound effect; textdraw.wav could also be used, but it would have to be copied into the in-mission sound section in sounds.tbl. Also adds an important detail to sexp help, and removes trailing whitespace in the script.
Goober5000
force-pushed
the
scrollwrite_sounds
branch
from
f54dcb9 to
35f96d5
Compare
Goober5000
added a commit
to Goober5000/fso-scripts
that referenced
this pull request
Jun 22, 2022
This adds an option to the sound handling so that an in-mission looping sound is played for as long as the text is scrolling, and then stops when the text finishes scrolling. Right now beep_5.wav is used as a placeholder sound effect; textdraw.wav could also be used, but it would have to be copied into the in-mission sound section in sounds.tbl. Also adds an important detail to sexp help, removes trailing whitespace in the script, and fixes tab-indentation. (Unfortunately the whitespace changes in `Scroll:Draw` make it appear that there are more changes than there really are. The main non-whitespace changes are the addition of the `line.Handle` management and the removal of the `finalString` variable.) This corresponds to the old PR 3: AxemP/AxemFS2Scripts#3
BMagnu
pushed a commit
to FSO-Scripters/fso-scripts
that referenced
this pull request
Jul 7, 2022
This adds an option to the sound handling so that an in-mission looping sound is played for as long as the text is scrolling, and then stops when the text finishes scrolling. Right now beep_5.wav is used as a placeholder sound effect; textdraw.wav could also be used, but it would have to be copied into the in-mission sound section in sounds.tbl. Also adds an important detail to sexp help, removes trailing whitespace in the script, and fixes tab-indentation. (Unfortunately the whitespace changes in `Scroll:Draw` make it appear that there are more changes than there really are. The main non-whitespace changes are the addition of the `line.Handle` management and the removal of the `finalString` variable.) This corresponds to the old PR 3: AxemP/AxemFS2Scripts#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to the sound handling so that an in-mission looping sound is played for as long as the text is scrolling, and then stops when the text finishes scrolling. Right now beep_5.wav is used as a placeholder sound effect; textdraw.wav could also be used, but it would have to be copied into the in-mission sound section in sounds.tbl.
Also adds an important detail to sexp help, removes trailing whitespace in the script, and fixes tab-indentation.
(Unfortunately the whitespace changes in
Scroll:Drawmake it appear that there are more changes than there really are. The main non-whitespace changes are the addition of theline.Handlemanagement and the removal of thefinalStringvariable.)