Skip to content

Conversation

@AxelUser
Copy link
Owner

@AxelUser AxelUser commented Jan 25, 2026

Summary by CodeRabbit

  • New Features

    • Added Air Cairo to the baggage allowances database (carry-on: 55×40×23 cm, 7 kg)
    • Introduced an on-page measurement tip to help users measure baggage dimensions
  • Accessibility

    • Improved screen-reader support for the main heading
  • SEO

    • Introduced a site SEO component and integrated it across pages to standardize meta and social metadata handling

✏️ Tip: You can customize this high-level summary in your review settings.

@AxelUser AxelUser self-assigned this Jan 25, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 25, 2026

📝 Walkthrough

Walkthrough

Replaces static SEO metadata in src/app.html with a new reusable Seo Svelte component and integrates it into the main and legal routes; adds an Air Cairo entry to cabin luggage allowances; exposes a baseUrl constant; removes a global plausible declaration; and updates a couple of tests and a layout import.

Changes

Cohort / File(s) Summary
SEO metadata & component
src/app.html, src/lib/components/seo/index.ts, src/lib/components/seo/seo.svelte, src/routes/+page.svelte, src/routes/legal/+layout.svelte
Removed static meta tags from app.html; added Seo Svelte component (re-exported via index.ts) that injects title, description, OG/Twitter, robots, and canonical tags; integrated Seo into main page and legal layout.
Airline allowances data
src/lib/allowances/cabin-luggage-allowances.ts
Appended a new airline entry for "Air Cairo" with carry-on dimensions (55×40×23 cm) and weight 7 kg.
Navigation util
src/lib/utils/navigation.ts
Added const baseUrl = 'https://carryon.fit' and exported it alongside existing links.
Global types
src/lib/globals.d.ts
Removed the top-level plausible(...) global function type declaration.
Layout import
src/routes/+layout.svelte
Added import of cookieConsent store (no other logic changes).
E2E tests
e2e/fixtures/test.ts
Relaxed Playwright heading selectors to check level: 1 instead of exact name matching.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰
I tunneled through tags, made meta neat,
From head to component, tidy and sweet.
Air Cairo hops in, luggage snug and light,
Canonicals hum softly into the night. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the two main changes: moving SEO meta-tags to a dedicated component and adding Air Cairo airline data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/routes/legal/`+layout.svelte:
- Around line 11-12: The Seo component in +layout.svelte is missing the url prop
so canonical links default to the homepage; update the Seo usage in
src/routes/legal/+layout.svelte to pass the actual page URL (e.g., compute from
SvelteKit's page store or from the layout data and pass as url={page.url.href}
or url={`${origin}${page.url.pathname}`}) to ensure each legal page has the
correct canonical URL, and optionally set noindex={true} on Seo for legal pages
if you prefer them excluded from search engines; modify the <Seo ... />
invocation accordingly.
🧹 Nitpick comments (1)
src/lib/components/seo/seo.svelte (1)

9-14: Hardcoded airlinesCount default may drift out of sync.

The default value of 170 doesn't match the actual airline count in the dataset (currently ~113 airlines). If this component is ever rendered without explicitly passing airlinesCount, the SEO description will display an incorrect number.

Consider either:

  1. Requiring airlinesCount as a mandatory prop (remove default), or
  2. Importing and using the actual count from the allowances data as the default

Since the main page already passes the correct value (airlinesCount={allAirlines.length}), this is low risk but could cause confusion in future usages.

@AxelUser AxelUser changed the title Feat: moving meta-tags for dedicated component and add Air Cairo Feat: move meta-tags to dedicated component and add Air Cairo Jan 25, 2026
@AxelUser AxelUser merged commit dfc7a7c into main Jan 25, 2026
2 checks passed
@AxelUser AxelUser deleted the feat/seo-impovements-25-01-26 branch January 25, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants