-
-
Notifications
You must be signed in to change notification settings - Fork 5
Feat: move meta-tags to dedicated component and add Air Cairo #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughReplaces static SEO metadata in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/routes/legal/`+layout.svelte:
- Around line 11-12: The Seo component in +layout.svelte is missing the url prop
so canonical links default to the homepage; update the Seo usage in
src/routes/legal/+layout.svelte to pass the actual page URL (e.g., compute from
SvelteKit's page store or from the layout data and pass as url={page.url.href}
or url={`${origin}${page.url.pathname}`}) to ensure each legal page has the
correct canonical URL, and optionally set noindex={true} on Seo for legal pages
if you prefer them excluded from search engines; modify the <Seo ... />
invocation accordingly.
🧹 Nitpick comments (1)
src/lib/components/seo/seo.svelte (1)
9-14: HardcodedairlinesCountdefault may drift out of sync.The default value of
170doesn't match the actual airline count in the dataset (currently ~113 airlines). If this component is ever rendered without explicitly passingairlinesCount, the SEO description will display an incorrect number.Consider either:
- Requiring
airlinesCountas a mandatory prop (remove default), or- Importing and using the actual count from the allowances data as the default
Since the main page already passes the correct value (
airlinesCount={allAirlines.length}), this is low risk but could cause confusion in future usages.
Summary by CodeRabbit
New Features
Accessibility
SEO
✏️ Tip: You can customize this high-level summary in your review settings.