Add a simple FileAppender type to log into a file without rotation. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a NoRollingCondition that implements the RollingCondition trait in order to never rollover. The goal is to provide a FileAppender type to log into a file without rotation behavior.
Now the struct who implement the RollingCondition trait have to know the maximum number of files autorized before rolling. Deprecation: Now the RollingFileAppender does not need to receive the max_files value as parameter because this value is provided by the condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a NoRollingCondition that implements the RollingCondition trait in order to never rollover.
The goal is to provide a FileAppender type to log into a file without rotation behavior.
The Context struct in testing submodule is now generic, this allows to write tests for anything that implements RollingCondition trait.
Thank you for reading.