Skip to content

Check whether the result of plugin is sorted #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dachengx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check whether the result of plugin is sorted #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b8cff6
Check whether the result of plugin is sorted
dachengx Sep 22, 2025
fa0cfb5
Debug
dachengx Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions strax/plugins/down_chunking_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,5 @@ def _fix_output(self, result, start, end, superrun, subruns, _dtype=None):
f"Plugin {self.__class__.__name__} should yield (dict of) "
"strax.Chunk in compute method."
)
self._check_sorted(_result)
yield self.superrun_transformation(_result, superrun, subruns)
13 changes: 13 additions & 0 deletions strax/plugins/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,18 @@ def _check_dtype(self, x, d=None):
f"Delivered: {got}."
)

def _check_sorted(self, result):
# check the result is sorted in time
if self.multi_output:
for d in self.provides:
self._check_sorted(result[d])

if len(result.data) < 2:
return

if np.diff(result.data["time"]).min() < 0:
raise ValueError(f"Plugin {self.__class__.__name__} did not return sorted time!")

@staticmethod
def _check_subruns_uniqueness(kwargs, subrunses):
"""Check if the subruns of the all inputs are the same."""
Expand Down Expand Up @@ -788,6 +800,7 @@ def _fix_output(self, result, start, end, superrun, subruns, _dtype=None):
f"{self.__class__.__name__} returned a Chunk with data_type "
f"{result.data_type} instead of {_dtype}."
)
self._check_sorted(result)
return self.superrun_transformation(result, superrun, subruns)

def chunk(self, *, start, end, data, data_type=None, run_id=None):
Expand Down
Loading