Skip to content

Update Navbar#48

Closed
Hrusikesh001 wants to merge 1 commit intoAvishkarPatil:mainfrom
Hrusikesh001:main
Closed

Update Navbar#48
Hrusikesh001 wants to merge 1 commit intoAvishkarPatil:mainfrom
Hrusikesh001:main

Conversation

@Hrusikesh001
Copy link
Contributor

📝 Description

  • This PR fixes the navbar layout issues caused by the global search feature integration.
  • Changes Made
  • Restored proper navbar structure and alignment.
  • Fixed layout issues caused by the search bar integration.
  • Ensured navigation links no longer overlap with the search input.
  • Improved mobile responsiveness (hamburger menu, spacing, stacking order).
  • Verified consistency with existing UI design.

Summary of Changes

1. New NGO Page Created

  • File: jalwiki_ui/app/ngo/page.tsx
  • Added a dedicated page for NGO initiatives with:
    - Search functionality for NGO initiatives
    - Sample NGO data (WaterAid India, Water For People India)
    - Related articles section
    - Water facts section
    - Responsive design consistent with the Government page

2. Government Page Updated

  • File: jalwiki_ui/app/gov/page.tsx
  • Removed NGO-related content (type: 'ngo')
  • Now displays only Government initiatives (National Water Mission, Jal Shakti Abhiyan, Atal Bhujal Yojana, Namami Gange Programme)
  • Updated search placeholder → "Search government schemes..."
  • Fixed "Clear Search" button functionality

3. Navigation Bar Updated
- File: jalwiki_ui/components/navbar.tsx
- Split "Gov & NGO" into two separate items:
- Government (Library icon) → /gov
- NGO (Users icon) → /ngo
- Updated isActive function to handle /ngo route
- Added Users icon from lucide-react

4. Content Separation
- Government Initiatives → exclusively government programs/schemes
- NGO Initiatives → new dedicated page highlighting NGO contributions

5. Visual & Functional Improvements
- Consistent styling and layout across both pages
- Independent search functionality for each page
- Proper handling of loading and empty states
- Fully responsive design across devices

🔗 Related Issue

Fixes #8

Screenshots/Demo

Before
Screenshot 2025-08-26 230249

After
Screenshot 2025-08-27 144042
Screenshot 2025-08-27 144111

@AvishkarPatil . I’ve updated the navbar . Could you please review & merge and let me know if it looks good?

@github-actions
Copy link

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@Hrusikesh001
Copy link
Contributor Author

@AvishkarPatil please review the changes and merge it

@Hrusikesh001
Copy link
Contributor Author

Hrusikesh001 commented Aug 28, 2025

@AvishkarPatil ???

@AvishkarPatil
Copy link
Owner

AvishkarPatil commented Aug 28, 2025

Thank you for taking the time to contribute to Jalwiki! However, I won't be merging this PR at this time. I plan to implement this feature as part of a more comprehensive solution that includes the backend API and Django models, rather than just the frontend changes. This will ensure better integration across the entire application.

I appreciate your effort, and please feel free to contribute to other areas of the project or discuss this approach further if you have any questions. @Hrusikesh001

@AvishkarPatil
Copy link
Owner

AvishkarPatil commented Aug 29, 2025

We will consider your contribution but can't not merge as there backend implementation is needed your efforts are not going waste I will add your score - Thanks for Contrtibution 🙌 @Hrusikesh001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Search Functionality

3 participants