Skip to content

Add theme popover with animation and improved icon selection#52

Merged
AvishkarPatil merged 3 commits intoAvishkarPatil:mainfrom
Sardar-Sadiq:issue-20
Sep 1, 2025
Merged

Add theme popover with animation and improved icon selection#52
AvishkarPatil merged 3 commits intoAvishkarPatil:mainfrom
Sardar-Sadiq:issue-20

Conversation

@Sardar-Sadiq
Copy link
Contributor

🔗 Related Issue

  • Closes #

🎯 Rationale

📝 Summary of Changes

Just created the mini theme menu box
image
In order to give the users option of themes

🔧 Technical Details

Used figma for design architecture

--> Used the react-lucid icons for icons
--> Used react-popover from radix-ui

✅ Testing

I tested toggle btn by changing theme multiple times

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing completed
  • All existing tests pass

Test Details

📚 Documentation

  • Code comments added/updated
  • README updated (if needed)
  • API documentation updated (if needed)
  • Migration guide provided (for breaking changes)

🔄 Breaking Changes

  • This PR contains breaking changes
  • Migration guide provided
  • Version updated appropriately

🎨 User-Facing Changes

Frontend Changes

  • UI components modified
  • New user interactions added
  • Styling/theme changes

Backend/API Changes

  • New endpoints added
  • Existing endpoints modified
  • Response format changes

📋 Checklist

Code Quality

  • Code follows project style guidelines
  • Self-review completed
  • No console.log or debug statements left
  • Error handling implemented appropriately

Review Readiness

  • PR title is descriptive and follows conventions
  • PR description is complete and accurate
  • Commits are atomic and well-documented
  • Branch is up to date with target branch

Security & Performance

  • No sensitive information exposed
  • Performance impact considered
  • Security implications reviewed

🚀 Deployment Notes

📸 Screenshots/Demo

🙏 Reviewer Notes


@github-actions
Copy link

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@Sardar-Sadiq
Copy link
Contributor Author

@AvishkarPatil Pls take a look at this the toggle has own mini menu box bro

@AvishkarPatil
Copy link
Owner

@Sardar-Sadiq Thanks for update I'll review & merge ASAP

@Sardar-Sadiq
Copy link
Contributor Author

thanks for review and when i can get update on my dashboard of OSCI ??

@AvishkarPatil AvishkarPatil merged commit 33d2d8b into AvishkarPatil:main Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants