This repository was archived by the owner on Oct 13, 2025. It is now read-only.
Fix dynamic resource propagation into TDG headers and Cells (wire up the logical tree)#361
Open
danwalmsley wants to merge 3 commits intomasterfrom
Open
Fix dynamic resource propagation into TDG headers and Cells (wire up the logical tree)#361danwalmsley wants to merge 3 commits intomasterfrom
danwalmsley wants to merge 3 commits intomasterfrom
Conversation
added 3 commits
May 16, 2025 11:07
…use the logical children are not wired up.
…nspect column headers and rows in the logical tree.
Member
|
Hmm, I've been unable to repro dynamic resources not propagating to headers and cells. Could you modify the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the presenter realises items it currently adds them to visual children, but it does not add them to the logical children.
Because of this dynamic resource changes (which are only propagated to logical children) do not reach the column headers or cells.
This PR fixes it by adding to the logical children when an item is first attached.
Iv also added an optional change which adds the presenters to the logical children so that column headers, rows and cells can be inspected in dev tools.
I dont remember the way to make it skip out the presenters themselves.