This repository was archived by the owner on Oct 13, 2025. It is now read-only.
CellsPresenter and use the RowsPresenter viewport instead of estimating#360
Open
danwalmsley wants to merge 2 commits intomasterfrom
Open
CellsPresenter and use the RowsPresenter viewport instead of estimating#360danwalmsley wants to merge 2 commits intomasterfrom
danwalmsley wants to merge 2 commits intomasterfrom
Conversation
added 2 commits
May 8, 2025 17:09
…lumns can be realized when estimating the viewport incorrectly.
grokys
approved these changes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some circumstances the CellsPresenter has to estimate the viewport… the problem is that it doesnt estimate the horizontal scroll offset, causing the all cells and columns to be realized.
In this scenario its actually more efficient and easier to get the viewport from the parent RowsPresenter.
Added a unit test to setup the scenario and prove the fix.