Framework: update to react 16 (take three)

[samouri]

Everyone knows the third time is the charm.

to do:

1. interpolate components: Bump to allow for React 16, fix test interpolate-components#12, Framework: Bump i18n-calypso to 1.8.4 #19658
2. fix ssr: enable user-bootstrapping when secrets are present #20267

To Test and Verify

1. local dev
2. docker. note: ssr will be broken unless secrets.json is configured.
3. there should be no reference to React < 16 within our shrinkwrap

[matticbot]

Test live: https://calypso.live/?branch=framework/react16-take3

[kwight]

Note that notifications-panel (the react16 branch aligned with this update) is now at 2.1.1.

[sirreal]

Note that notifications-panel (the react16 branch aligned with this update) is now at 2.1.1.

@kwight 2.1.1 does not seem to be published yet 😬

[sirreal]

This had become quite out of date.

Rebased, notifications-panel@2.1.0, update-deps, force push.

[sirreal]

Rebased again, sorry. notifications@2.1.0 was causing errors. Back to 2.0.0

[kwight]

Ack, will verify 2.1.1.

[kwight]

notifications-panel@2.1.1 published 👍

[samouri]

I'm basing this off the ssr fix now

[samouri]

🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 
⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ready for testing  ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ 
🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑

[sirreal]

I've done the following smoke testing and encountered no issues 🎉

• local dev
• docker. note: ssr will be broken unless secrets.json is configured.
• there should be no reference to React < 16 within our shrinkwrap

For SSR I see /themes is correct (logged in and logged out) if config/secrets.json is included. Otherwise I see the following message and the issue pictured here.

Disabling server-side user-bootstrapping because of a missing secrets.json

[sirreal]

Should we get the current 2.1.1?

[samouri]

also React 16.2!

[sirreal]

Love those <>Fragments</> 🎉

[sirreal]

Running tests now produces far fewer warnings, which is nice. Now we have a new annoyance:

console.error node_modules/fbjs/lib/warning.js:33
Warning: React depends on requestAnimationFrame. Make sure that you load a polyfill in older browsers. http://fb.me/react-polyfills

Relevant conversation seems to be happening here: jestjs/jest#4545. Just a warning, so nothing blocking and we can ship a fix later.

[ockham]

Also bump to 16.2.0?

[samouri]

I've had to bump back down to 2.0 due to issues withesnext

[ockham]

I've had to bump back down to 2.0 due to issues withesnext

My bad. Context: #19698

To fix, we can:

• either merge Framework: Transpile untranspiled node_modules, Take Two #19698
• or change back esnext to module in https://github.com/Automattic/notifications-panel
• or add a build step, publish that to npm, and set main to point to the dir that holds the transpiled code

[samouri]

To fix, we can:

Am I right in thinking that can all happen after this PR lands?

[samouri]

after upgrading a few packages (and then redowngrading notif-panel), i'll do another smoke test and then ask for an E2E from flow-patrol

[ockham]

Am I right in thinking that can all happen after this PR?

Oh, absolutely! Sry for not having been clear 😄

[ockham]

Am I right in thinking that can all happen after this PR?

Oh, absolutely! Sry for not having been clear 😄

As pretty much anything that doesn't make Calypso go up in 🔥s at this point 😄

[bsessions85]

E2E tests passed