fix(dev-env): defer querying site details #2683
Merged
+3
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
rebeccahum
reviewed
Jan 6, 2026
| public async getSiteUrlsFromSDS(): Promise< WpSite[] > { | ||
| if ( | ||
| this.env.isMultisite && |
Contributor
There was a problem hiding this comment.
We shouldn't remove this
|
rebeccahum
approved these changes
Jan 6, 2026
sjinks
deleted the
pltfrm-1891-vip-cli-returns-error-unauthorized-instead-of-prompting-for
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move querying of site details out of the application query to fix permission issues.
Changelog Description
Fixed
vip dev-env sync sql: query site details only when they are needed. This fixes the issue with permissions when@app.envis not specified.Pull request checklist
New release checklist
Steps to Test
vip dev-env @vip-permissions-test-wp.production sync sqlmust not fail until the "Preparing for backup download" phasevip dev-env sync sqlmust ask for app/env instead of failing with "Unauthorized" error.