Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Conversation

@matiasbenedetto
Copy link
Member

@matiasbenedetto matiasbenedetto commented Jul 14, 2022

Changes proposed in this Pull Request:

Implementing button styles for Club theme

Related issue(s):

fixes: #6215

image

@matiasbenedetto matiasbenedetto requested a review from a team July 14, 2022 11:41
"text": "var(--wp--preset--color--foreground)"
},
"border": {
"color": "var(--wp--preset--color--foreground)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires this Gutenberg PR to work. WordPress/gutenberg#42053
Otherwise, the border property is overridden by the default block styles.

Copy link
Contributor

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outline button has no border in editor.

Editor Frontend
image image

Post comment button is different from fill button style.
post-comment

@matiasbenedetto
Copy link
Member Author

Thanks for your feedback!

Outline button has no border in editor.

The outline button in the editor should be fixed with the latest commit.

Post comment button is different from fill button style.

To work as expected we need this PR to be merged as I pointed out in this comment before.

Copy link
Contributor

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matiasbenedetto matiasbenedetto merged commit 60b83e3 into trunk Jul 18, 2022
@pbking pbking deleted the add/6215 branch July 18, 2022 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

club: Styles: Buttons

3 participants