Add initial .pot file and extract pot generation to a reusable lane#2658
Add initial .pot file and extract pot generation to a reusable lane#2658
Conversation
sejas
left a comment
There was a problem hiding this comment.
The code looks good! AFAIU, the .pot file is tracked in Git, so a cron job can use it to update GlotPress. However, I think that file won’t be added back to trunk until the release is completed and the PR is back-merged. @iangmaia , is that right? If so, it will be hard to translate the new strings that are added in the new release.
|
We do backmerge PRs at different stages of the release process, including:
I expect we generate the updated This assumes that your beta-testing phase will be long enough for translators to translate new strings, so if your typical beta-testing phase (time between code-freeze and release finalization) lasts 2 weeks (well, ≈ 12 open days) for example that should be plenty enough. If you beta-testing phase is 1 week only, it might or might not be tight depending on the amount of new strings you have to translate and the reactivity of translators, though in most products this is usually still enough. But still good point to be conscious about! 👍 |
🎯 Yep, that's exactly it 👍 So @sejas the GlotPress upload will be from the code freeze. That way, the set of strings being added to a given release is also part of the release. |
638798a to
dacb487
Compare
📊 Performance Test ResultsComparing dacb487 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Related issues
Proposed Changes
.potfile generation logic from thecode_freezelane into a standalonegenerate_pot_filelane, making it reusable by other lanes (e.g.finalize_release)i18n/bundle-strings.potfile to version control so it can be used as a baseline for future string extractionTesting Instructions
generate_pot_filelane can be invoked independently:bundle exec fastlane generate_pot_filePre-merge Checklist