[Tooling] Add Buildkite release pipelines and fastlane lanes for ReleasesV2

.buildkite/commands/build-for-windows.ps1

@@ -46,8 +46,6 @@ if ($BuildType -eq $BUILD_TYPE_DEV) {
     $env:IS_DEV_BUILD="true"
 } else {
     Write-Host "Preparing release build..."
-    node ./scripts/confirm-tag-matches-version.mjs
-	If ($LastExitCode -ne 0) { Exit $LastExitCode }
 }
 
 # Set architecture environment variable for AppX packaging

.buildkite/commands/checkout-release-branch.sh

@@ -0,0 +1,25 @@
+#!/bin/bash -eu
+
+# Script to checkout a specific release branch.
+# Usage: ./checkout-release-branch.sh <RELEASE_VERSION>
+#
+# Buildkite, by default, checks out a specific commit, ending up in a detached HEAD state.
+# But in some cases, we need to ensure to be checked out on the `release/*` branch instead, namely:
+# - When a `release-pipelines/*.yml` will end up needing to do a `git push` to the `release/*` branch (for version bumps)
+# - When doing a new build from a job that was `pipeline upload`'d by such a pipeline,
+#   to ensure that the job doing the build would include that recent extra commit before starting the build.
+
+echo "--- :git: Checkout Release Branch"
+
+if [[ -n "${1:-}" ]]; then
+  RELEASE_VERSION="$1"
+elif [[ "${BUILDKITE_BRANCH:-}" =~ ^release/ ]]; then
+  RELEASE_VERSION="${BUILDKITE_BRANCH#release/}"
+else
+  echo "Error: RELEASE_VERSION parameter missing and BUILDKITE_BRANCH is not a release branch"
+  exit 1
+fi
+BRANCH_NAME="release/${RELEASE_VERSION}"
+
+git fetch origin "$BRANCH_NAME"
+git checkout -B "$BRANCH_NAME" "origin/$BRANCH_NAME"

.buildkite/pipeline.yml

@@ -181,98 +181,3 @@ steps:
     notify:
       - github_commit_status:
           context: Distribute Dev Builds
-
-  - group: 📦 Build for Mac
-    key: release-mac
-    steps:
-      - label: 🔨 Mac Release Build - {{matrix}}
-        agents:
-          queue: mac
-        command: |
-          .buildkite/commands/prepare-environment.sh
-
-          .buildkite/commands/install-node-dependencies.sh
-          node ./scripts/confirm-tag-matches-version.mjs
-
-          echo "--- :node: Building Binary"
-          npm run make:macos-{{matrix}}
-
-          # Local trial and error show this needs to run before the DMG generation (obviously) but after the binary has been built
-          echo "--- :hammer: Rebuild fs-attr if necessary before generating DMG"
-          case {{matrix}} in
-            x64)
-              echo "Rebuilding fs-xattr for {{matrix}} architecture"
-              npm rebuild fs-xattr --cpu universal
-              ;;
-            arm64)
-              echo "No need to rebuild fs-xattr because it works out of the box on Apple Silicon"
-              ;;
-            *)
-              echo "^^^ +++ Unexpected architecture {{matrix}}"
-              exit 1
-              ;;
-          esac
-
-          echo "--- :node: Packaging in DMG"
-          npm run make:dmg-{{matrix}}
-
-          echo "--- 📃 Notarizing Binary"
-          bundle exec fastlane notarize_binary
-        plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
-        artifact_paths:
-          - apps/studio/out/**/*.app.zip
-          - apps/studio/out/*.dmg
-        matrix:
-          - x64
-          - arm64
-        notify:
-          - github_commit_status:
-              context: All Mac Release Builds
-    if: build.tag =~ /^v[0-9]+/
-
-  - group: 📦 Build for Windows
-    key: release-windows
-    steps:
-      - label: 🔨 Windows Release Build - {{matrix}}
-        agents:
-          queue: windows
-        command: powershell -File .buildkite/commands/build-for-windows.ps1 -BuildType release -Architecture {{matrix}}
-        artifact_paths:
-          - apps\studio\out\**\studio-setup.exe
-          - apps\studio\out\**\studio-update.nupkg
-          - apps\studio\out\**\RELEASES
-          - apps\studio\out\**\*.appx
-        plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
-        matrix:
-          - x64
-          - arm64
-        notify:
-          - github_commit_status:
-              context: All Windows Release Builds
-    if: build.tag =~ /^v[0-9]+/
-
-  - label: ":rocket: Publish Release Builds"
-    command: |
-      echo "--- :node: Downloading Binaries"
-      buildkite-agent artifact download "*.zip" .
-      buildkite-agent artifact download "*.dmg" .
-      buildkite-agent artifact download "*.exe" .
-      buildkite-agent artifact download "*.appx" .
-      buildkite-agent artifact download "*.nupkg" .
-      buildkite-agent artifact download "*\\RELEASES" .
-
-      .buildkite/commands/install-node-dependencies.sh
-
-      echo "--- :fastlane: Distributing Release Builds"
-      install_gems
-      bundle exec fastlane distribute_release_build
-    agents:
-      queue: mac
-    depends_on:
-      - step: release-mac
-      - step: release-windows
-    plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
-    if: build.tag =~ /^v[0-9]+/
-    notify:
-      - github_commit_status:
-          context: Publish Release Builds

.buildkite/release-build-and-distribute.yml

@@ -0,0 +1,115 @@
+# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
+#
+# Release build and distribution pipeline.
+#
+# Triggered as a separate Buildkite build by the fastlane lanes (code_freeze, new_beta_release,
+# finalize_release) via `buildkite_add_trigger_step` / `buildkite_trigger_build`.
+#
+# Expects `RELEASE_VERSION` env var to be set (e.g., '1.7.4').
+# Each step checks out the release branch to ensure it builds the latest commit.
+---
+
+# Used by mac agents only
+env:
+  IMAGE_ID: $IMAGE_ID
+
+steps:
+  - group: 📦 Build for Mac
+    key: release-mac
+    steps:
+      - label: 🔨 Mac Release Build - {{matrix}}
+        agents:
+          queue: mac
+        command: |
+          .buildkite/commands/checkout-release-branch.sh "${RELEASE_VERSION}"
+
+          .buildkite/commands/prepare-environment.sh
+
+          .buildkite/commands/install-node-dependencies.sh
+
+          echo "--- :node: Building Binary"
+          npm run make:macos-{{matrix}}
+
+          # Local trial and error show this needs to run before the DMG generation (obviously) but after the binary has been built
+          echo "--- :hammer: Rebuild fs-attr if necessary before generating DMG"
+          case {{matrix}} in
+            x64)
+              echo "Rebuilding fs-xattr for {{matrix}} architecture"
+              npm rebuild fs-xattr --cpu universal
+              ;;
+            arm64)
+              echo "No need to rebuild fs-xattr because it works out of the box on Apple Silicon"
+              ;;
+            *)
+              echo "^^^ +++ Unexpected architecture {{matrix}}"
+              exit 1
+              ;;
+          esac
+
+          echo "--- :node: Packaging in DMG"
+          npm run make:dmg-{{matrix}}
+
+          echo "--- 📃 Notarizing Binary"
+          bundle exec fastlane notarize_binary
+        plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
+        artifact_paths:
+          - apps/studio/out/**/*.app.zip
+          - apps/studio/out/*.dmg
+        matrix:
+          - x64
+          - arm64
+        notify:
+          - github_commit_status:
+              context: All Mac Release Builds
+
+  - group: 📦 Build for Windows
+    key: release-windows
+    steps:
+      - label: 🔨 Windows Release Build - {{matrix}}
+        agents:
+          queue: windows
+        command: |
+          bash .buildkite/commands/checkout-release-branch.sh "${RELEASE_VERSION}"
+          powershell -File .buildkite/commands/build-for-windows.ps1 -BuildType release -Architecture {{matrix}}
+        artifact_paths:
+          - apps\studio\out\**\studio-setup.exe
+          - apps\studio\out\**\studio-update.nupkg
+          - apps\studio\out\**\RELEASES
+          - apps\studio\out\**\*.appx
+        plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
+        matrix:
+          - x64
+          - arm64
+        notify:
+          - github_commit_status:
+              context: All Windows Release Builds
+
+  - label: ":rocket: Publish Release Builds"
+    command: |
+      echo "--- :robot_face: Use bot for Git operations"
+      source use-bot-for-git
+
+      .buildkite/commands/checkout-release-branch.sh "${RELEASE_VERSION}"
+
+      echo "--- :node: Downloading Binaries"
+      buildkite-agent artifact download "*.zip" .
+      buildkite-agent artifact download "*.dmg" .
+      buildkite-agent artifact download "*.exe" .
+      buildkite-agent artifact download "*.appx" .
+      buildkite-agent artifact download "*.nupkg" .
+      buildkite-agent artifact download "*\\RELEASES" .
+
+      .buildkite/commands/install-node-dependencies.sh
+
+      echo "--- :fastlane: Distributing Release Builds"
+      install_gems
+      bundle exec fastlane distribute_release_build
+    agents:
+      queue: mac
+    depends_on:
+      - step: release-mac
+      - step: release-windows
+    plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
+    notify:
+      - github_commit_status:
+          context: Publish Release Builds

.buildkite/release-pipelines/code-freeze.yml

@@ -0,0 +1,29 @@
+# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
+---
+
+env:
+  IMAGE_ID: $IMAGE_ID
+
+steps:
+  - label: ":snowflake: Code Freeze"
+    plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
+    command: |
+      echo "--- :robot_face: Use bot for Git operations"
+      source use-bot-for-git
+
+      echo "--- :npm: Install Node dependencies"
+      .buildkite/commands/install-node-dependencies.sh
+
+      echo "--- :ruby: Setup Ruby Tools"
+      install_gems
+
+      echo "--- :snowflake: Execute Code Freeze"
+      bundle exec fastlane code_freeze version:"${RELEASE_VERSION}" github_username:"${GITHUB_USERNAME}" skip_confirm:true
+    artifact_paths:
+      - i18n/bundle-strings.pot
+    agents:
+      queue: mac
+    retry:
+      manual:
+        reason: If release jobs fail, you should always re-trigger the task from Releases V2 rather than retrying the individual job from Buildkite
+        allowed: false

.buildkite/release-pipelines/download-translations.yml

@@ -0,0 +1,26 @@
+# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
+---
+
+env:
+  IMAGE_ID: $IMAGE_ID
+
+steps:
+  - label: ":earth_asia: Download Translations"
+    plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
+    command: |
+      echo "--- :robot_face: Use bot for Git operations"
+      source use-bot-for-git
+
+      .buildkite/commands/checkout-release-branch.sh "${RELEASE_VERSION}"
+
+      echo "--- :ruby: Setup Ruby Tools"
+      install_gems
+
+      echo "--- :earth_asia: Download Translations"
+      bundle exec fastlane download_translations github_username:"${GITHUB_USERNAME}" skip_confirm:true
+    agents:
+      queue: mac
+    retry:
+      manual:
+        reason: If release jobs fail, you should always re-trigger the task from Releases V2 rather than retrying the individual job from Buildkite
+        allowed: false

.buildkite/release-pipelines/finalize-release.yml

@@ -0,0 +1,26 @@
+# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
+---
+
+env:
+  IMAGE_ID: $IMAGE_ID
+
+steps:
+  - label: ":checkered_flag: Finalize Release"
+    plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
+    command: |
+      echo "--- :robot_face: Use bot for Git operations"
+      source use-bot-for-git
+
+      .buildkite/commands/checkout-release-branch.sh "${RELEASE_VERSION}"
+
+      echo "--- :ruby: Setup Ruby Tools"
+      install_gems
+
+      echo "--- :checkered_flag: Finalize Release"
+      bundle exec fastlane finalize_release version:"${RELEASE_VERSION}" skip_confirm:true
+    agents:
+      queue: mac
+    retry:
+      manual:
+        reason: If release jobs fail, you should always re-trigger the task from Releases V2 rather than retrying the individual job from Buildkite
+        allowed: false

.buildkite/release-pipelines/new-beta-release.yml

@@ -0,0 +1,26 @@
+# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
+---
+
+env:
+  IMAGE_ID: $IMAGE_ID
+
+steps:
+  - label: ":package: New Beta Release"
+    plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
+    command: |
+      echo "--- :robot_face: Use bot for Git operations"
+      source use-bot-for-git
+
+      .buildkite/commands/checkout-release-branch.sh "${RELEASE_VERSION}"
+
+      echo "--- :ruby: Setup Ruby Tools"
+      install_gems
+
+      echo "--- :package: Create New Beta"
+      bundle exec fastlane new_beta_release version:"${RELEASE_VERSION}" skip_confirm:true
+    agents:
+      queue: mac
+    retry:
+      manual:
+        reason: If release jobs fail, you should always re-trigger the task from Releases V2 rather than retrying the individual job from Buildkite
+        allowed: false

.buildkite/release-pipelines/new-hotfix-release.yml

@@ -0,0 +1,24 @@
+# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
+---
+
+env:
+  IMAGE_ID: $IMAGE_ID
+
+steps:
+  - label: ":fire: New Hotfix Release"
+    plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
+    command: |
+      echo "--- :robot_face: Use bot for Git operations"
+      source use-bot-for-git
+
+      echo "--- :ruby: Setup Ruby Tools"
+      install_gems
+
+      echo "--- :fire: Create New Hotfix"
+      bundle exec fastlane new_hotfix_release version:"${RELEASE_VERSION}" skip_confirm:true
+    agents:
+      queue: mac
+    retry:
+      manual:
+        reason: If release jobs fail, you should always re-trigger the task from Releases V2 rather than retrying the individual job from Buildkite
+        allowed: false