-
Notifications
You must be signed in to change notification settings - Fork 275
Account for navigation bars in the transcripts UI #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes edge-to-edge display issues in the transcripts UI, specifically addressing content obstruction by 3-button navigation bars.
Changes:
- Added window insets padding to the subscription button in the transcripts paywall
- Added bottom spacing to transcript lines to prevent obstruction by navigation bars
- Updated CHANGELOG.md to document the bug fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TranscriptsPaywall.kt | Added window insets padding to the CTA button to prevent navigation bar obstruction |
| TranscriptLines.kt | Added spacer item with window insets bottom height to prevent last transcript line from being hidden |
| CHANGELOG.md | Added entry documenting the navigation bar obstruction fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Description
Currently transcripts UI does not handle edge-to-edge well especially when 3-button navigation is enabled. This fixes that.
Closes PCDROID-240
Testing Instructions
Screenshots or Screencast
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...