-
Notifications
You must be signed in to change notification settings - Fork 275
[Installments] Update cancel confirmation screen #4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/installments-disable-switch
Are you sure you want to change the base?
[Installments] Update cancel confirmation screen #4891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the cancellation confirmation screen to provide specific messaging for users on 12-month installment payment plans through Google Play. The changes ensure users understand that cancelling their Pocket Casts subscription doesn't stop their Google Play payment obligations.
Changes:
- Added three new localized strings for installment-specific messaging
- Updated the cancel confirmation UI to conditionally display installment-specific content
- Added a Compose preview for the installment cancellation flow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/services/localization/src/main/res/values/strings.xml | Added three new strings: installment header description, installment perk message, and history accessibility message |
| modules/features/profile/src/main/java/au/com/shiftyjelly/pocketcasts/profile/winback/WinbackFragment.kt | Passed isInstallment state to CancelConfirmationPage component |
| modules/features/profile/src/main/java/au/com/shiftyjelly/pocketcasts/profile/winback/CancelConfirmationPage.kt | Updated UI to conditionally show installment-specific messaging, added history perk row for installments, and created installment-specific preview |
| <string name="winback_cancel_subscription_perk_files">All files uploaded to your Pocket Casts account will be deleted (but downloaded files on your mobile devices will remain).</string> | ||
| <string name="winback_cancel_subscription_perk_history">Your podcasts and listening history will continue to be accessible.</string> | ||
| <string name="winback_cancel_subscription_header_description_installment">Cancelling ends your Pocket Casts subscription.\nYour Google Play payment plan will continue.</string> | ||
| <string name="winback_cancel_subscription_perk_installment">You\'re on a 12-month installment plan. Cancelling ends your access, but Google Play will continue charging the remaining months.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be misunderstanding this, but cancelling doesn't end your access to Plus straight away, right?
Description
This PR updates the cancellation confirmation screen in sync with the linked p2 discussion.
P2: pdeCcb-aGD-p2#comment-8759
Fixes PCDROID-391
Testing Instructions
Check preview
Screenshots or Screencast
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml