Skip to content

Conversation

@sztomek
Copy link
Contributor

@sztomek sztomek commented Jan 13, 2026

Description

This PR updates the cancellation confirmation screen in sync with the linked p2 discussion.

P2: pdeCcb-aGD-p2#comment-8759

Fixes PCDROID-391

Testing Instructions

Check preview

Screenshots or Screencast

SCR-20260113-smof

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@sztomek sztomek added this to the 8.4 milestone Jan 13, 2026
@sztomek sztomek requested a review from a team as a code owner January 13, 2026 20:20
@sztomek sztomek requested review from Copilot and geekygecko and removed request for a team January 13, 2026 20:20
@sztomek sztomek added [Type] Feature Adding a new feature. [Area] Subscriptions Plus or Patron issue labels Jan 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the cancellation confirmation screen to provide specific messaging for users on 12-month installment payment plans through Google Play. The changes ensure users understand that cancelling their Pocket Casts subscription doesn't stop their Google Play payment obligations.

Changes:

  • Added three new localized strings for installment-specific messaging
  • Updated the cancel confirmation UI to conditionally display installment-specific content
  • Added a Compose preview for the installment cancellation flow

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
modules/services/localization/src/main/res/values/strings.xml Added three new strings: installment header description, installment perk message, and history accessibility message
modules/features/profile/src/main/java/au/com/shiftyjelly/pocketcasts/profile/winback/WinbackFragment.kt Passed isInstallment state to CancelConfirmationPage component
modules/features/profile/src/main/java/au/com/shiftyjelly/pocketcasts/profile/winback/CancelConfirmationPage.kt Updated UI to conditionally show installment-specific messaging, added history perk row for installments, and created installment-specific preview

<string name="winback_cancel_subscription_perk_files">All files uploaded to your Pocket Casts account will be deleted (but downloaded files on your mobile devices will remain).</string>
<string name="winback_cancel_subscription_perk_history">Your podcasts and listening history will continue to be accessible.</string>
<string name="winback_cancel_subscription_header_description_installment">Cancelling ends your Pocket Casts subscription.\nYour Google Play payment plan will continue.</string>
<string name="winback_cancel_subscription_perk_installment">You\'re on a 12-month installment plan. Cancelling ends your access, but Google Play will continue charging the remaining months.</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be misunderstanding this, but cancelling doesn't end your access to Plus straight away, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Subscriptions Plus or Patron issue [Type] Feature Adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants