[Installments] Hide plan switching when user is subscribed to installments plan #4890
+33
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sztomek
requested review from
MiSikora and
Copilot
and removed request for
a team
sztomek
added
[Type] Feature
sztomek
force-pushed
the
feat/installments-disable-switch
branch
from
5be80b8 to
a63edde
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hides the plan switching option in the winback flow when users are subscribed to an installment plan, addressing PCDROID-392.
Changes:
- Added
isInstallmentfield to WinbackViewModel's UiState to track installment subscription status - Modified CancelOfferPage to conditionally hide the "Available Plans" section based on installment status
- Updated subscription flow to propagate installment status from cached subscription
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| WinbackViewModel.kt | Added isInstallment field to UiState and updated subscription flow collection to populate it from cached subscription |
| WinbackFragment.kt | Passed isInstallment parameter from state to CancelOfferPage composable |
| CancelOfferPage.kt | Added conditional rendering to hide AvailablePlans section when isInstallment is true, updated preview parameter |
Comment on lines
+48
to
+51
| _uiState.value = _uiState.value.copy( | ||
| currentSubscriptionExpirationDate = subscription?.expiryDate, | ||
| isInstallment = subscription?.isInstallment ?: false, | ||
| ) |
There was a problem hiding this comment.
The new isInstallment field in UiState lacks test coverage. Since this file has comprehensive unit tests for other ViewModel functionality, tests should be added to verify that the isInstallment value is correctly propagated from the subscription flow to the UI state. Consider adding a test that verifies when a subscription with isInstallment = true is emitted, the UiState correctly reflects this value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hides the plan switching option when the user is subscribed to the installments plan in sync with the link P2 discussion.
P2: pdeCcb-aGD-p2#comment-8759
Fixes PCDROID-392
Testing Instructions
Check previews
Screenshots or Screencast
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml