-
Notifications
You must be signed in to change notification settings - Fork 275
Remove Radioactivity theme #4888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the Radioactivity UI theme from the Pocket Casts Android app due to maintenance costs and the theme's obscurity. The changes properly remove all theme-related code while preserving the Radioactivity app icon, as intended. Users currently using the Radioactivity theme will automatically fall back to the default dark theme on update.
Changes:
- Removed Radioactivity theme from theme generation scripts, XML resources, and Kotlin code
- Removed theme-specific UI logic from Compose components and features
- Removed RadioactiveLineView usage from MainActivity
- Updated CHANGELOG.md with the removal
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/themes/generate_xml.rb | Removed radioactive theme from XML generation script |
| scripts/themes/generate_kotlin.rb | Removed radioactive theme from Kotlin generation script and cleaned up commented code |
| scripts/themes/download_themes.rb | Removed radioactive theme data mapping |
| modules/services/ui/src/main/res/values/themes.xml | Removed BaseRadioactive and RadioactiveControlStyle theme definitions |
| modules/services/ui/src/main/res/values/colors.xml | Removed radioactive-specific color resource |
| modules/services/ui/src/main/res/values-v27/themes.xml | Removed API 27+ Radioactive theme override |
| modules/services/ui/src/main/java/au/com/shiftyjelly/pocketcasts/ui/theme/ThemeColor.kt | Removed all radioactive color constants and theme mappings, removed unused import |
| modules/services/ui/src/main/java/au/com/shiftyjelly/pocketcasts/ui/theme/Theme.kt | Removed RADIOACTIVE ThemeType enum and mapping |
| modules/services/preferences/src/main/java/au/com/shiftyjelly/pocketcasts/preferences/model/ThemeSetting.kt | Removed RADIOACTIVE setting enum |
| modules/services/images/src/main/res/drawable/ic_theme_radioactive.xml | Deleted radioactive theme icon |
| modules/services/compose/.../SparkleImage.kt | Removed radioactive sparkle colors |
| modules/services/compose/.../Theme.kt | Removed radioactive theme mapping and color filter logic, cleaned up unused imports |
| modules/services/compose/.../PocketCastsColors.kt | Removed radioactive green color constant |
| modules/services/compose/.../Colors.kt | Removed ThemeRadioactiveColors definition |
| modules/features/settings/.../SettingsAppearanceViewModel.kt | Removed radioactive theme from analytics mapping |
| modules/features/profile/.../WinbackOfferPage.kt | Removed radioactive heart colors |
| modules/features/player/.../ChaptersHeader.kt | Removed radioactive preview |
| modules/features/player/.../ChapterRow.kt | Removed radioactive preview |
| modules/features/endofyear/.../EndOfYearPromptCard.kt | Removed radioactive-specific text color and image filter logic |
| modules/features/endofyear/.../EndOfYearLaunchBottomSheet.kt | Removed radioactive image color filter |
| app/src/main/res/layout/activity_main.xml | Removed RadioactiveLineView from layout |
| app/src/main/java/au/com/shiftyjelly/pocketcasts/ui/MainActivity.kt | Removed RadioactiveLineView management code |
| CHANGELOG.md | Added entry for Radioactivity theme removal |
sztomek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transition from radioactive to the default theme went well. App works fine.
ps: liked your branch name :)
|
I'll wait with merging until Automattic/pocket-casts-ios#3865 is ready. |
Description
Due to the maintenance costs and theme's obscurity we're removing it.
Closes PCDROID-209
Closes POC-319
Closes POC-284
Closes POC-282
Closes POC-280
Testing Instructions
mehow/task/radioactive-decay.Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...