Skip to content

Conversation

@MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Jan 13, 2026

Description

Due to the maintenance costs and theme's obscurity we're removing it.

Closes PCDROID-209
Closes POC-319
Closes POC-284
Closes POC-282
Closes POC-280

Testing Instructions

  1. Install the app from deab9dd.
  2. Sign in with a Plus account.
  3. Change the theme to Radioactivity.
  4. Install the app from mehow/task/radioactive-decay.
  5. Open the app.
  6. The theme should change to the app's default theme.
  7. Go to the appearance settings.
  8. Notice that there is no Radioactivity theme.
  9. Notice that the Radioactivity app icon is still available.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@MiSikora MiSikora added this to the 8.4 milestone Jan 13, 2026
@MiSikora MiSikora requested a review from a team as a code owner January 13, 2026 11:21
@MiSikora MiSikora requested review from Copilot and sztomek and removed request for a team January 13, 2026 11:21
@MiSikora MiSikora added [Type] Tech Debt Involving upgrades or refactoring to maintain or enhance the codebase. [Area] Theme labels Jan 13, 2026
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 13, 2026

1 Error
🚫 This PR is tagged with do not merge label(s).
1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Radioactivity UI theme from the Pocket Casts Android app due to maintenance costs and the theme's obscurity. The changes properly remove all theme-related code while preserving the Radioactivity app icon, as intended. Users currently using the Radioactivity theme will automatically fall back to the default dark theme on update.

Changes:

  • Removed Radioactivity theme from theme generation scripts, XML resources, and Kotlin code
  • Removed theme-specific UI logic from Compose components and features
  • Removed RadioactiveLineView usage from MainActivity
  • Updated CHANGELOG.md with the removal

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/themes/generate_xml.rb Removed radioactive theme from XML generation script
scripts/themes/generate_kotlin.rb Removed radioactive theme from Kotlin generation script and cleaned up commented code
scripts/themes/download_themes.rb Removed radioactive theme data mapping
modules/services/ui/src/main/res/values/themes.xml Removed BaseRadioactive and RadioactiveControlStyle theme definitions
modules/services/ui/src/main/res/values/colors.xml Removed radioactive-specific color resource
modules/services/ui/src/main/res/values-v27/themes.xml Removed API 27+ Radioactive theme override
modules/services/ui/src/main/java/au/com/shiftyjelly/pocketcasts/ui/theme/ThemeColor.kt Removed all radioactive color constants and theme mappings, removed unused import
modules/services/ui/src/main/java/au/com/shiftyjelly/pocketcasts/ui/theme/Theme.kt Removed RADIOACTIVE ThemeType enum and mapping
modules/services/preferences/src/main/java/au/com/shiftyjelly/pocketcasts/preferences/model/ThemeSetting.kt Removed RADIOACTIVE setting enum
modules/services/images/src/main/res/drawable/ic_theme_radioactive.xml Deleted radioactive theme icon
modules/services/compose/.../SparkleImage.kt Removed radioactive sparkle colors
modules/services/compose/.../Theme.kt Removed radioactive theme mapping and color filter logic, cleaned up unused imports
modules/services/compose/.../PocketCastsColors.kt Removed radioactive green color constant
modules/services/compose/.../Colors.kt Removed ThemeRadioactiveColors definition
modules/features/settings/.../SettingsAppearanceViewModel.kt Removed radioactive theme from analytics mapping
modules/features/profile/.../WinbackOfferPage.kt Removed radioactive heart colors
modules/features/player/.../ChaptersHeader.kt Removed radioactive preview
modules/features/player/.../ChapterRow.kt Removed radioactive preview
modules/features/endofyear/.../EndOfYearPromptCard.kt Removed radioactive-specific text color and image filter logic
modules/features/endofyear/.../EndOfYearLaunchBottomSheet.kt Removed radioactive image color filter
app/src/main/res/layout/activity_main.xml Removed RadioactiveLineView from layout
app/src/main/java/au/com/shiftyjelly/pocketcasts/ui/MainActivity.kt Removed RadioactiveLineView management code
CHANGELOG.md Added entry for Radioactivity theme removal

Copy link
Contributor

@sztomek sztomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transition from radioactive to the default theme went well. App works fine.
ps: liked your branch name :)

@MiSikora
Copy link
Contributor Author

I'll wait with merging until Automattic/pocket-casts-ios#3865 is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Theme do not merge [Type] Tech Debt Involving upgrades or refactoring to maintain or enhance the codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants