trigger error when concatenation is blocked #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinatkhaziev
reviewed
Jan 6, 2025
| sprintf( | ||
| 'Cannot concatenate over %d files in %s', | ||
| $concat_max_files, | ||
| $_SERVER['REQUEST_URI'] |
Contributor
There was a problem hiding this comment.
Would this actually be ngx-http-concat.php's URI?
Contributor
Author
There was a problem hiding this comment.
Error I captured in a sandbox environment (truncated middle for readability) :
PHP message: PHP Warning: Cannot concatenate over 150 files in /_static/??-eJy...Nv6Bufg== in /var/www/wp-content/mu-plugins/http-concat/ngx-http-concat.php on line 120
Contributor
There was a problem hiding this comment.
@trepmal in that case is the url helpful in any meaningful way in terms of providing information for debug?
Contributor
Author
There was a problem hiding this comment.
there are several cases which could result in a 400. I think it's helpful to have the info just in case there are multiple issues.
#78 could make this moot though
Contributor
There was a problem hiding this comment.
Yes, I think with #78 merged this may be closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.