fix(memberships): restrict commenting to relevant statuses

[chickenn00dle]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/NPPM-2524/bug-woo-member-commenting-module-allows-cancelled-memberships-to

This PR fixes an issue where readers with cancelled subscriptions are able to comment when the woo-member-commenting module is active and enabled.

We do this by filtering by status when checking a given readers subscriptions (Proposed by Adam Leone in the Linear task).

How to test the changes in this Pull Request:

1. Set up the woo-member-commenting module (See instructions on that below
2. Ensure commenting is enabled in WordPress settings
3. As a non-subscribed reader, visit a restricted post associated with a membership plan and verify you are not able to comment on the post
4. Subscribe to the relevant subscription to gain access
5. Verify you can now comment
6. Cancel the subscription as the reader so it is in pending-cancel state
7. Verify you can still comment
8. As admin, fully cancel the subscription
9. As reader, verify you can no longer comment

Setting up woo member commenting:

1. Run the following command: wp newspack optional-module activate woo-member-commenting
2. Add the following snippet to wp-config.php:

const NP_WC_MEMBER_COMMENT_SETTINGS = [
  'membership_plan_slug'        => [''], // Slug(s) of membership plans. 
  'membership_purchase_post_id'     => 6, // Post id to a page/post with membershipt tease
  'membership_required_message' => "Become a member, why don't cha?",
];

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[Copilot]

Pull request overview

This PR restricts commenting access to users with active memberships by filtering membership statuses when checking user permissions for the woo-member-commenting module. The fix prevents users with cancelled subscriptions from commenting on restricted posts.

Changes:

• Added status filtering to wc_memberships_get_user_memberships() call to only include active membership statuses
• Explicitly passed user ID to the membership query function

Comments suppressed due to low confidence (1)

includes/optional-modules/class-woo-member-commenting.php:127

• The caching logic is inverted. When $skip_cache is false and a cached value exists (not null), the function should return the cached value. However, the current condition returns the cached value when $skip_cache is true, which defeats the purpose of the skip parameter. The condition should be if ( ! $skip_cache && null !== $require_membership_to_comment ) to properly use cached values unless explicitly skipped.

		if ( $skip_cache || null !== $require_membership_to_comment ) {
			return $require_membership_to_comment;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[matticbot]

🎉 This PR is included in version 6.28.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀