Skip to content

Conversation

@dkoo
Copy link
Contributor

@dkoo dkoo commented Nov 17, 2025

All Submissions:

Changes proposed in this Pull Request:

Prevents the Woo checkout session from refreshing the modal checkout iframe upon checkout failure after creating a new customer account during checkout.

How to test the changes in this Pull Request:

See Automattic/newspack-blocks#2255 for testing instructions.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Nov 17, 2025
@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 17, 2025
@dkoo dkoo marked this pull request as ready for review November 17, 2025 21:59
@dkoo dkoo requested a review from a team as a code owner November 17, 2025 21:59
@dkoo dkoo requested a review from Copilot November 17, 2025 22:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the WooCommerce checkout session incorrectly triggers a modal checkout iframe reload after a new customer account is created during checkout, especially when the checkout fails.

Key Changes:

  • Adds a new hook handler for woocommerce_checkout_order_processed to prevent unwanted session reloads
  • Clears the reload_checkout session value when processing orders in modal checkout context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dkoo dkoo requested a review from laurelfulford November 21, 2025 17:18
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 21, 2025
@dkoo dkoo merged commit 89208fc into trunk Nov 21, 2025
8 checks passed
@dkoo dkoo deleted the fix/anon-transaction-failures branch November 21, 2025 20:30
@github-actions
Copy link

Hey @dkoo, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Nov 27, 2025
# [6.26.0-alpha.1](v6.25.1...v6.26.0-alpha.1) (2025-11-27)

### Bug Fixes

* **content-gifting:** ux tweaks and other fixes ([#4318](#4318)) ([952dd83](952dd83))
* **contrib-meter:** ensure percentage follows bar progress when using linear style ([#4320](#4320)) ([cbe8665](cbe8665))
* hide Content Gate CPT from WP Admin menu ([#4321](#4321)) ([70bbe7e](70bbe7e))
* make some Collections spacing more specific to archive pages ([#4293](#4293)) ([21daeaf](21daeaf))
* **media:** move default image UI to Advanced Settings ([#4296](#4296)) ([a22f06d](a22f06d))
* **modal-checkout:** prevent session reload after new customer account ([#4310](#4310)) ([89208fc](89208fc))
* **my-account:** add payment method query var ([#4325](#4325)) ([a7f2cb1](a7f2cb1))
* **my-account:** select font size ([#4324](#4324)) ([31a48c0](31a48c0))
* repeat button block styles in collections for WP 6.9 ([#4319](#4319)) ([6e3c5f8](6e3c5f8))
* **subscription-modal:** limited subscriptions ([#4309](#4309)) ([715f3c9](715f3c9))

### Features

* add autocomplete + token + multiselect component ([#4289](#4289)) ([84a8eda](84a8eda))
* **content-gifting:** custom article link expiration ([#4313](#4313)) ([c00f054](c00f054))
* listen to gforms events for newsletters ([#4312](#4312)) ([2f0e0e3](2f0e0e3))
* **my-account:** add "Product" column to the Subscriptions page ([#4323](#4323)) ([ba91e4c](ba91e4c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.26.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 2, 2025
# [6.27.0-alpha.1](v6.26.0...v6.27.0-alpha.1) (2025-12-02)

### Bug Fixes

* **content-gifting:** ux tweaks and other fixes ([#4318](#4318)) ([952dd83](952dd83))
* **contrib-meter:** ensure percentage follows bar progress when using linear style ([#4320](#4320)) ([cbe8665](cbe8665))
* hide Content Gate CPT from WP Admin menu ([#4321](#4321)) ([70bbe7e](70bbe7e))
* make some Collections spacing more specific to archive pages ([#4293](#4293)) ([21daeaf](21daeaf))
* **media:** move default image UI to Advanced Settings ([#4296](#4296)) ([a22f06d](a22f06d))
* **modal-checkout:** prevent session reload after new customer account ([#4310](#4310)) ([89208fc](89208fc))
* **my-account:** add payment method query var ([#4325](#4325)) ([a7f2cb1](a7f2cb1))
* **my-account:** select font size ([#4324](#4324)) ([31a48c0](31a48c0))
* repeat button block styles in collections for WP 6.9 ([#4319](#4319)) ([6e3c5f8](6e3c5f8))
* **subscription-modal:** limited subscriptions ([#4309](#4309)) ([715f3c9](715f3c9))

### Features

* add autocomplete + token + multiselect component ([#4289](#4289)) ([84a8eda](84a8eda))
* **content-gifting:** custom article link expiration ([#4313](#4313)) ([c00f054](c00f054))
* listen to gforms events for newsletters ([#4312](#4312)) ([2f0e0e3](2f0e0e3))
* **my-account:** add "Product" column to the Subscriptions page ([#4323](#4323)) ([ba91e4c](ba91e4c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.27.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 8, 2025
# [6.27.0](v6.26.4...v6.27.0) (2025-12-08)

### Bug Fixes

* **content-gifting:** ux tweaks and other fixes ([#4318](#4318)) ([952dd83](952dd83))
* **contrib-meter:** ensure percentage follows bar progress when using linear style ([#4320](#4320)) ([cbe8665](cbe8665))
* hide Content Gate CPT from WP Admin menu ([#4321](#4321)) ([70bbe7e](70bbe7e))
* make some Collections spacing more specific to archive pages ([#4293](#4293)) ([21daeaf](21daeaf))
* **media:** move default image UI to Advanced Settings ([#4296](#4296)) ([a22f06d](a22f06d))
* **modal-checkout:** prevent session reload after new customer account ([#4310](#4310)) ([89208fc](89208fc))
* **my-account:** add payment method query var ([#4325](#4325)) ([a7f2cb1](a7f2cb1))
* **my-account:** select font size ([#4324](#4324)) ([31a48c0](31a48c0))
* repeat button block styles in collections for WP 6.9 ([#4319](#4319)) ([6e3c5f8](6e3c5f8))
* **subscription-modal:** limited subscriptions ([#4309](#4309)) ([715f3c9](715f3c9))

### Features

* add autocomplete + token + multiselect component ([#4289](#4289)) ([84a8eda](84a8eda))
* **content-gifting:** custom article link expiration ([#4313](#4313)) ([c00f054](c00f054))
* listen to gforms events for newsletters ([#4312](#4312)) ([2f0e0e3](2f0e0e3))
* **my-account:** add "Product" column to the Subscriptions page ([#4323](#4323)) ([ba91e4c](ba91e4c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants