Skip to content

Conversation

@adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixes an issue with #3811 – it's written to only handle images hosted by the site. This PR fixes it, so any not-found image will be replaced by the fallback (default) image.

This is an alpha-hotfix, since the changes are already on alpha branch.

How to test the changes in this Pull Request:

  1. Repeat testing steps from feat(media): enable setting a default image for 404 images #3811, but also use a broken image link to a different site. https://nothing.here/image would suffice.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 31, 2025
@adekbadek adekbadek requested a review from a team as a code owner March 31, 2025 09:50
@adekbadek
Copy link
Member Author

PHP tests are failing today for code added in #3484. Something weird about running this code on this particular date. Not related to changes in this PR, these tests also fail on another PR submitted today (#3871).

Copy link
Member

@naxoc naxoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it works with images from different domains. 👍

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 31, 2025
@adekbadek adekbadek merged commit 51998b8 into alpha Mar 31, 2025
8 of 9 checks passed
@adekbadek adekbadek deleted the alpha-hotfix/image-404-handling branch March 31, 2025 10:59
@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.2.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @alpha [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants