Hovercards: Add hideOnTargetClick option & Remove hovercards after calling the detach()#216
Merged
Hovercards: Add hideOnTargetClick option & Remove hovercards after calling the detach()#216
hideOnTargetClick option & Remove hovercards after calling the detach()#216Conversation
added 2 commits
June 26, 2025 18:25
|
Size Change: +1.5 kB (+2.35%) Total Size: 65.5 kB
|
aaronfc
approved these changes
Jun 27, 2025
aaronfc
left a comment
There was a problem hiding this comment.
LGTM and works as described!
A small note: can you review if package-lock.json needs to be updated? When I run npm install I got it updated.
Contributor
Author
Thank you for the review. I have updated the file as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #210
Proposed Changes
hideOnTargetClickoption to hide the hovercard when its trigger element is clickeddetach()now removes attached hovercardsTesting Instructions
cd web/packages/hovercards && npm run build:watchcd web/packages/hovercards && npm run startTest the
hideOnTargetClickoptionhideOnTargetClicktofalse(or remove it). In the left section, the click-to-hide functionality should be canceledTest the
detachmethod_hideHovercardfunction