Skip to content

Translate contact field labels#195

Merged
jom merged 2 commits intotrunkfrom
fix/translate-contact-fields
Apr 22, 2025
Merged

Translate contact field labels#195
jom merged 2 commits intotrunkfrom
fix/translate-contact-fields

Conversation

@jom
Copy link
Member

@jom jom commented Apr 21, 2025

Fixes #194

Proposed Changes

  • Translate contact field labels (not related to a specific service such as Calendly)
  • Switch to using s.gravatar.com (static CDN) instead of secure.gravatar.com for assets.

Testing Instructions

  • npm run build and npm run start
  • Check the new second inline card to test translations

@jom jom self-assigned this Apr 21, 2025
@jom jom requested review from a team, jcheringer and wellyshen and removed request for jcheringer and wellyshen April 21, 2025 18:07
@github-actions
Copy link

Size Change: +1 kB (+1.59%)

Total Size: 64 kB

Filename Size Change
dist/index.esm.js 9.38 kB +159 B (+1.72%)
dist/index.js 9.52 kB +161 B (+1.72%)
dist/index.mjs 9.38 kB +159 B (+1.72%)
dist/index.react.js 11.6 kB +175 B (+1.53%)
dist/index.react.mjs 11.6 kB +176 B (+1.54%)
dist/index.react.umd.js 6.76 kB +89 B (+1.33%)
dist/index.umd.js 5.79 kB +85 B (+1.49%)

compressed-size-action

Copy link

@aaronfc aaronfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well!

@jom jom merged commit 4b372e9 into trunk Apr 22, 2025
2 checks passed
@jom jom deleted the fix/translate-contact-fields branch April 22, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contact fields aren't translated

2 participants

Comments