Hovercards: Add claim gravatar to the error status#190
Merged
Conversation
|
Size Change: +1.37 kB (+2.22%) Total Size: 63 kB
|
jom
reviewed
Apr 18, 2025
web/packages/hovercards/src/core.ts
Outdated
| ? ` | ||
| <i class="gravatar-hovercard__error-message gravatar-hovercard__error-message--claim-gravatar"> | ||
| ${ __t( this._i18n, 'Is this you?' ) } | ||
| <a href="http://gravatar.com/signup" target="_blank">${ __t( this._i18n, 'Claim your free profile.' ) }</a> |
Member
There was a problem hiding this comment.
Let's add something that we can use to track these clicks. utm_source?
Contributor
Author
There was a problem hiding this comment.
@jom Good point, I have added it, thanks!
added 2 commits
April 18, 2025 19:08
jom
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #191
Proposed Changes
additionalMessageoption to thecreateHovercardErrormethodTesting Instructions
cd web/packages/hovercards && npm run build:watchnpm run start