Conversation
thedebian
left a comment
There was a problem hiding this comment.
Worked well 👍
Looking for md5 through the code, I think we can remove browser/md5 which references the removed npm package in package.json.
There's also a weird component.json which seems to be a sort of package.json, but not synced with it, I'm not sure what we should do with that.
Nice catch, don't know how I missed that
I think this is an attempt at something like npm, or a replacement for it? All these "components" would be downloadable from some central repository. I've seen reference to other components. I don't know what to do with it either because I don't know how to test it. Everything in https://github.com/webmodules/ seems to support this component framework. Found this link https://github.com/componentjs/component it was abandoned in 2019. |
This PR updates the hashing algorithm to sha256 which is now supported by Gravatar.com
This PR is also duplicated in the original repo with the hopes it gets integrated there as well, and updated in NPM. Otherwise, we can use this repo for imports for internal products (like Cloudup)
Testing
node -e "var gravatar = require('./index.js'); console.log(gravatar.url('someemail@example.com'))"node -e "var gravatar = require('./index.js'); console.log(gravatar.url('someemail@example.com', {s: 20}))"