Reset shared image cache on docker pull failure #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue identified at Automattic/wp-calypso#103848 (comment)
The
pullImagefunction uses internal state to ensure that multiple concurrent pulls are only executed a single time.After a pull succeeds or fails via some
docker pullprogress result, the state value is released so that future pulls can try again (source). However, if thedocker pullfails before it gets to progress updates (e.g. "Not found"), the state value is never released, and subsequent pull attempts will always fail, even if the image would eventually become available, such as the situation described in Automattic/wp-calypso#103848 (comment).The changes here ensure that the state value is consistently released after the pull finishes, successfully or otherwise.
Testing Instructions:
Verify test coverage fails when changes to
src/api.tsare reset: